Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add Cypress testing for SQL Workbench #562

Merged
merged 7 commits into from
Aug 17, 2020
Merged

Add Cypress testing for SQL Workbench #562

merged 7 commits into from
Aug 17, 2020

Conversation

joshuali925
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Add cypress for Workbench sanity test, add test cases

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chloe-zh
Copy link
Member

Could you present an example of what the generated cypress test looks like?

Copy link
Member

@chloe-zh chloe-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes!

Copy link

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@joshuali925 joshuali925 merged commit d7b1c04 into opendistro-for-elasticsearch:develop Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants