Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Rename odbc release artifacts #1010

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Rename odbc release artifacts #1010

merged 1 commit into from
Jan 27, 2021

Conversation

joshuali925
Copy link
Contributor

Issue #, if available:

Description of changes:
rename odbc artifacts before uploading to S3 from

Open Distro for Elasticsearch SQL ODBC Driver 64-bit-1.12.0.0-Darwin.pkg
Open Distro for Elasticsearch SQL ODBC Driver 64-bit-1.12.0.0-Windows.msi
Open Distro for Elasticsearch SQL ODBC Driver 32-bit-1.12.0.0-Windows.msi

to

opendistro-sql-odbc-1.12.0.x-macos-x64.pkg
opendistro-sql-odbc-1.12.0.x-windows-x64.msi
opendistro-sql-odbc-1.12.0.x-windows-x86.msi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #1010 (ba056ac) into develop (43f41bd) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1010   +/-   ##
==========================================
  Coverage      99.87%   99.87%           
  Complexity      2406     2406           
==========================================
  Files            234      234           
  Lines           5524     5526    +2     
  Branches         357      357           
==========================================
+ Hits            5517     5519    +2     
  Misses             5        5           
  Partials           2        2           
Impacted Files Coverage Δ Complexity Δ
...sql/elasticsearch/response/error/ErrorMessage.java 100.00% <0.00%> (ø) 9.00% <0.00%> (ø%)
...rotocol/response/format/JdbcResponseFormatter.java 100.00% <0.00%> (ø) 11.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f41bd...ba056ac. Read the comment docs.

Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking generate the artifact with the expected name directly when ODBC build. But I found many reference to old name in Github action and documentation. Is that the reason we'd rather rename it at the final step?

@joshuali925
Copy link
Contributor Author

I was thinking generate the artifact with the expected name directly when ODBC build. But I found many reference to old name in Github action and documentation. Is that the reason we'd rather rename it at the final step?

Yes, peter suggested it could be easier to rename after it builds than changing build params, since I'm not very familiar with cmake

@davidcui1225 davidcui1225 merged commit bf31e1c into opendistro-for-elasticsearch:develop Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants