This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Added API Routes and Zeppelin Backend Adaptor #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ps48
changed the title
chloe-zh
reviewed
Aug 13, 2020
server/routes/paraRouter.ts
Outdated
| // Delete a paragraph | ||
| router.delete( | ||
| { | ||
| path: `${API_PREFIX}/para/{ids*2}`, |
There was a problem hiding this comment.
can you explain this {ids*2}? I've never seen this syntax in an API route
There was a problem hiding this comment.
From Hapi Docs: https://hapi.dev/tutorials/routing/?lang=en_US#-multi-segment-parameters
So, in short if you have multiple segments to a route e.g here /api/{noteId}/{paragraphId}, you can specify number of dynamic segments with a "number" (/api/{id*2})and then split id with a "/" to get noteId and paragraphId
chloe-zh
approved these changes
Aug 15, 2020
ps48
added a commit
that referenced
this pull request
Aug 21, 2020
* Initial Commit - new platform, gitignore, license header (#18) * initial commit with new platform structure * adding gitignore * adding Amazon header * added .DS_Store in gitignore, added header in app.tsx (#23) * Added API Routes and Zeppelin Backend Adaptor (#24) * added .DS_Store in gitignore, added header in app.tsx * adding API routes and backend adaptor with Zeppelin * changed para to paragraph for all parameters, simplified backend assignment * modified error catches in Zeppelin Backend, modified API endpoints for paragraphs * renamed functions and added parameter documentation * propagating error message to UI * added new route for visualizations and minor edits to noterouter (#25) * added new RFC, supporting docs and images (#29) * added dashboard dependency, added main, notebook and note_buttons component (#27) * Added paragraph components and UI helpers (#28) * added helpers and paragraph components * added more documentation, minor refactors * Updating docs and adding Zeppelin Patch PoC (#30) * adding zeppelin patch to poc, moving docs, updating default scehma * fixing typo in README * removed cloning command, added comments for elasticsearch client configuration * adding link to clone notebooks repo * Updated workflow documentation, fixed link to POC (#33) * updating screenshot, adding documentation for workflow/schema * fixing link to POC * updated docuemntation with usage, more images and example notebook * updating schema doc and build link fix * typo fix in API doc and usage doc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.