Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xcy): fix render settings when using gymnasium #173

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

HarryXuancy
Copy link
Contributor

@HarryXuancy HarryXuancy commented Dec 22, 2023

  • fix the problem of render resulting from changing gym to gymnasium in gymnasium render mode should be specified when environment is created and the render function should not receive argument of render mode.
  • for example:
self._env = gym.make('CartPole-v0', render_mode="rgb_array")
...
if self._save_replay_gif:
            self._frames.append(self._env.render())

@puyuan1996 puyuan1996 added bug Something isn't working config New or improved configuration labels Dec 22, 2023
@puyuan1996 puyuan1996 changed the title Fixrender fix(pu): fix render setting when using gymnasium Dec 22, 2023
@puyuan1996 puyuan1996 changed the title fix(pu): fix render setting when using gymnasium fix(xcy): fix render setting when using gymnasium Dec 22, 2023
@puyuan1996 puyuan1996 changed the title fix(xcy): fix render setting when using gymnasium fix(xcy): fix render settings when using gymnasium Dec 22, 2023
@puyuan1996 puyuan1996 merged commit 95e94b9 into opendilab:main Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working config New or improved configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants