feature(pu): adapt to unizero-multitask ddp, and adapt ppo to support jericho config #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
puyuan1996
commented
Mar 12, 2025
ding/worker/learner/learner_hook.py
Outdated
| else: | ||
| self._freq = ext_args.freq | ||
| self._freq = ext_args.get('freq', 1) | ||
| self._only_monitor_rank0 = ext_args.get('only_monitor_rank0', True) |
Collaborator
Author
There was a problem hiding this comment.
不过有个问题是 LogShowHook 在/ding/worker/learner/learner_hook.py初始化时，好像都是用的默认参数，写死在hook_mapping这里了，unizero_multitask 使用时还是要改这个文件吧
Member
There was a problem hiding this comment.
用engine.only_monitor_rank0，而不是自己传进来的
PaParaZz1
requested changes
Mar 12, 2025
PaParaZz1
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adapt learner to unizero-multitask ddp, and adapt vac to support jericho config
Related Issue
TODO
Check List