Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(whl): add SIL policy #675

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

feature(whl): add SIL policy #675

wants to merge 27 commits into from

Conversation

kxzxvbk
Copy link
Contributor

@kxzxvbk kxzxvbk commented Jun 9, 2023

Description

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@PaParaZz1 PaParaZz1 added the algo Add new algorithm or improve old one label Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #675 (be90f73) into main (6b188c9) will decrease coverage by 0.24%.
The diff coverage is 33.07%.

❗ Current head be90f73 differs from pull request most recent head 86f69c2. Consider uploading reports for the commit 86f69c2 to get more accurate results

@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
- Coverage   82.06%   81.82%   -0.24%     
==========================================
  Files         586      592       +6     
  Lines       47515    47896     +381     
==========================================
+ Hits        38991    39190     +199     
- Misses       8524     8706     +182     
Flag Coverage Δ
unittests 81.82% <33.07%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/policy/sil.py 13.13% <13.13%> (ø)
ding/entry/serial_entry_sil.py 21.53% <21.53%> (ø)
ding/entry/__init__.py 100.00% <100.00%> (ø)
ding/policy/__init__.py 100.00% <100.00%> (ø)
ding/policy/command_mode_policy_instance.py 93.86% <100.00%> (+0.16%) ⬆️
ding/rl_utils/__init__.py 100.00% <100.00%> (ø)
ding/rl_utils/sil.py 100.00% <100.00%> (ø)
ding/rl_utils/tests/test_sil.py 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algo Add new algorithm or improve old one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants