Cypress Cloud integration #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Christian Schweikert <[email protected]>
Co-authored-by: Christian Schweikert <[email protected]>
removed unneeded comment
modified README.md
cypress cloud
cschweikert
requested changes
Jun 29, 2023
| @@ -43,6 +43,34 @@ In order to generate one xml report per test type (installation, integration and | |||
| With Cypress 12 version is now available `cy.origin()` that allows you to handle redirections. This funcionality eases the login handling. | |||
| See `./support/e2e.ts` for a generic login example. | |||
|
|
|||
| ## Cypress Cloud | |||
There was a problem hiding this comment.
I would move the whole section into the documentation of cypress (https://github.com/opendevstack/ods-quickstarters/blob/master/docs/modules/quickstarters/pages/e2e-cypress.adoc). The focus of the README.md should be more on getting started. Maybe only leave a short note about general support for Cypress Cloud with a link to the documentation.
e2e-cypress/files/README.md
Outdated
| ## Cypress Cloud | ||
|
|
||
| To use Cypress Cloud, follow these steps: | ||
| 1. **Request access.** In order to access Cypress Cloud, you will need to request access to the AAD group. This can be done through MyServices using the Active Directory Group - Administration Request form. Once access has been granted, you will be able to log into https://cloud.cypress.io/login using your mail. |
There was a problem hiding this comment.
This point refers to internal processes of a specific organization. I would not mention those within an open source project. Maybe rephrase this and the following point to be more general.
There was a problem hiding this comment.
Seems that @roicarrera already modified the Readme accordingly.
cschweikert
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added integration with cypress cloud. Has to be set manually, explained in the readme.
Changed agent node version to node 18