Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonar upgrade to 8.9 LTS #1096

Merged
merged 13 commits into from
Jan 31, 2023
Merged

Sonar upgrade to 8.9 LTS #1096

merged 13 commits into from
Jan 31, 2023

Conversation

BraisVQ
Copy link
Contributor

@BraisVQ BraisVQ commented Feb 1, 2022

michaelsauter
michaelsauter previously approved these changes Feb 1, 2022
michaelsauter
michaelsauter previously approved these changes Feb 1, 2022
@stitakis stitakis self-requested a review February 7, 2022 14:40
Copy link
Member

@stitakis stitakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm disapproving this change to avoid merging it right now. The ods-core build is broken since days. I'd like to get this fixed before adding more functionality. @braisvq1996 if you have time it would be awesome if you could have a quick look and figure out why the current build is failing. Please let me know. Thanks!

@gerardcl
Copy link
Member

gerardcl commented Feb 7, 2022

Hi @stitakis , not sure why you would block this PR, this is not a new functionality but a required upgrade, the ods-devenv issue is unrelated to this upgrade IMHO, so I don't see a need to block this based on your last comment. Sorry.

@gerardcl
Copy link
Member

gerardcl commented Feb 7, 2022

We have agreed to release this PR via ODS 4.2.0 release, so the focus will be to first fix master along with releasing current planned 4.1.0 ODS version.

@stitakis
Copy link
Member

stitakis commented Feb 8, 2022

@gerardcl @braisvq1996 @michaelsauter to get everyone on same page... do we agree to first fix the ODS AMI build for master and 4.x and then merge this PR? Is this the plan?

@victorpablosceruelo
Copy link
Contributor

Hi all.
The current status changed to green for the master branch and will change to green for the 4.x branch in one hour (more or less).
If everything goes well, we expect having green state for 3.x soon too.
Enjoy!!

@@ -54,25 +54,10 @@ COPY run.sh $SONARQUBE_HOME/bin/
RUN mkdir -p /opt/configuration/sonarqube/plugins
# General plugins
ADD https://github.com/deepy/sonar-crowd/releases/download/2.1.3/sonar-crowd-plugin-2.1.3.jar /opt/configuration/sonarqube/plugins/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sonar-crowd repo was archived.
So drop this software?

Copy link
Contributor Author

@BraisVQ BraisVQ Jan 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last suported version is 8.9 that is the one this PR will update to.
For this version we can stil use it but for the next LTS version (9.9) this plugin will not be available.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, could this PR then merged or what is left after fixing merge conflicts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this has been pending for near a year....
Right now I am trying to make this part of the next release bundle and as soon as this is done we will review the PR and merge it

Copy link
Member

@gerardcl gerardcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@BraisVQ BraisVQ merged commit cce288b into opendevstack:master Jan 31, 2023
@BraisVQ BraisVQ deleted the sonar-upgrade branch January 31, 2023 16:26
@michaelsauter
Copy link
Member

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants