-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonar upgrade to 8.9 LTS #1096
Sonar upgrade to 8.9 LTS #1096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm disapproving this change to avoid merging it right now. The ods-core build is broken since days. I'd like to get this fixed before adding more functionality. @braisvq1996 if you have time it would be awesome if you could have a quick look and figure out why the current build is failing. Please let me know. Thanks!
Hi @stitakis , not sure why you would block this PR, this is not a new functionality but a required upgrade, the ods-devenv issue is unrelated to this upgrade IMHO, so I don't see a need to block this based on your last comment. Sorry. |
We have agreed to release this PR via ODS 4.2.0 release, so the focus will be to first fix master along with releasing current planned 4.1.0 ODS version. |
@gerardcl @braisvq1996 @michaelsauter to get everyone on same page... do we agree to first fix the ODS AMI build for |
b3c991d
to
1bff8ff
Compare
Hi all. |
@@ -54,25 +54,10 @@ COPY run.sh $SONARQUBE_HOME/bin/ | |||
RUN mkdir -p /opt/configuration/sonarqube/plugins | |||
# General plugins | |||
ADD https://github.com/deepy/sonar-crowd/releases/download/2.1.3/sonar-crowd-plugin-2.1.3.jar /opt/configuration/sonarqube/plugins/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crowd plugin releases says one thing: https://github.com/deepy/sonar-crowd/releases
But SonarQube docs says another: https://docs.sonarqube.org/latest/instance-administration/plugin-version-matrix/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sonar-crowd repo was archived.
So drop this software?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last suported version is 8.9 that is the one this PR will update to.
For this version we can stil use it but for the next LTS version (9.9) this plugin will not be available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, could this PR then merged or what is left after fixing merge conflicts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this has been pending for near a year....
Right now I am trying to make this part of the next release bundle and as soon as this is done we will review the PR and merge it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
🎉 |
closes #1075
closes #986
@gerardcl @michaelsauter @metmajer