Skip to content
This repository was archived by the owner on Sep 4, 2025. It is now read-only.

Dockerfile.ubi: set uvicorn logging level#129

Merged
dtrifiro merged 2 commits into
opendatahub-io:mainfrom
dtrifiro:uvicorn-logging-level
Aug 20, 2024
Merged

Dockerfile.ubi: set uvicorn logging level#129
dtrifiro merged 2 commits into
opendatahub-io:mainfrom
dtrifiro:uvicorn-logging-level

Conversation

@dtrifiro
Copy link
Copy Markdown

@dtrifiro dtrifiro commented Aug 13, 2024

set vllm_tgis_adapter unicorn log level to warning

@openshift-ci openshift-ci Bot requested review from Xaenalt and z103cb August 13, 2024 21:29
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dtrifiro
Copy link
Copy Markdown
Author

Merge after #128

@njhill
Copy link
Copy Markdown

njhill commented Aug 13, 2024

@dtrifiro could we do this in such a way that we could still override if back to info if wanted?

@dtrifiro dtrifiro force-pushed the uvicorn-logging-level branch from f9ac7a7 to 438d7d1 Compare August 19, 2024 09:25
@dtrifiro dtrifiro enabled auto-merge (rebase) August 19, 2024 09:26
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 19, 2024

@dtrifiro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/smoke-test 438d7d1 link true /test smoke-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dtrifiro dtrifiro disabled auto-merge August 20, 2024 17:19
@dtrifiro dtrifiro merged commit 19adb9d into opendatahub-io:main Aug 20, 2024
@dtrifiro dtrifiro deleted the uvicorn-logging-level branch August 20, 2024 17:20
@dtrifiro
Copy link
Copy Markdown
Author

@njhill Sorry, I'm only seeing your comment now. I guess this can be overridden by changing the entrypoint itself. If this is not optimal we can revert this and have this set via env var in the adapter.

Xaenalt pushed a commit that referenced this pull request Sep 18, 2024
* Re-enable FusedRoPE for Gaudi1

* add fallback impl of rope
prarit pushed a commit to prarit/vllm that referenced this pull request Oct 18, 2024
* Add support for a rope extension method (vllm-project#6553)

* [BugFix] Fix RoPE error in Llama 3.1 (vllm-project#6693)

---------

Co-authored-by: Simon Mo <simon.mo@hey.com>
Co-authored-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants