Fix use of LoRA tokenizers#40
Merged
Merged
Conversation
njhill
commented
Jul 12, 2024
799aa72 to
44cb46f
Compare
Contributor
|
Merge after #47 |
44cb46f to
64bc05d
Compare
dtrifiro
reviewed
Jul 18, 2024
dtrifiro
reviewed
Jul 18, 2024
5880ac1 to
503f7f2
Compare
prashantgupta24
approved these changes
Jul 18, 2024
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
===========================================
- Coverage 62.96% 30.75% -32.21%
===========================================
Files 18 18
Lines 1250 1278 +28
Branches 222 228 +6
===========================================
- Hits 787 393 -394
- Misses 390 881 +491
+ Partials 73 4 -69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on vLLM PR vllm-project/vllm#6227, which is only held up because I need to find time to add a test to it.