Skip to content

Fix use of LoRA tokenizers#40

Merged
dtrifiro merged 8 commits into
mainfrom
lora-tokenizers
Jul 18, 2024
Merged

Fix use of LoRA tokenizers#40
dtrifiro merged 8 commits into
mainfrom
lora-tokenizers

Conversation

@njhill

@njhill njhill commented Jul 12, 2024

Copy link
Copy Markdown
Contributor

This depends on vLLM PR vllm-project/vllm#6227, which is only held up because I need to find time to add a test to it.

@njhill njhill requested a review from dtrifiro July 12, 2024 22:03
Comment thread src/vllm_tgis_adapter/grpc/grpc_server.py
@njhill njhill marked this pull request as ready for review July 18, 2024 14:45
@dtrifiro

Copy link
Copy Markdown
Contributor

Merge after #47

Comment thread tests/conftest.py
Comment thread tests/test_grpc_server.py Outdated
@dtrifiro dtrifiro force-pushed the lora-tokenizers branch 2 times, most recently from 5880ac1 to 503f7f2 Compare July 18, 2024 16:59
@dtrifiro dtrifiro enabled auto-merge July 18, 2024 17:06
@codecov-commenter

codecov-commenter commented Jul 18, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.75%. Comparing base (d32cfb1) to head (8aa1f95).
⚠️ Report is 253 commits behind head on main.

Files with missing lines Patch % Lines
src/vllm_tgis_adapter/grpc/grpc_server.py 14.28% 23 Missing and 1 partial ⚠️
tests/conftest.py 60.00% 7 Missing and 1 partial ⚠️
tests/test_grpc_server.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #40       +/-   ##
===========================================
- Coverage   62.96%   30.75%   -32.21%     
===========================================
  Files          18       18               
  Lines        1250     1278       +28     
  Branches      222      228        +6     
===========================================
- Hits          787      393      -394     
- Misses        390      881      +491     
+ Partials       73        4       -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dtrifiro dtrifiro added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 0b69d69 Jul 18, 2024
@dtrifiro dtrifiro deleted the lora-tokenizers branch July 18, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants