Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ refactor for using StatLoggerBase #22

Closed
wants to merge 2 commits into from
Closed

♻️ refactor for using StatLoggerBase #22

wants to merge 2 commits into from

Conversation

prashantgupta24
Copy link
Contributor

@prashantgupta24 prashantgupta24 commented Jul 1, 2024 •
edited
Loading

Based on vllm-project/vllm#5925 (should be merged after the upstream code is released)

@prashantgupta24 prashantgupta24 requested a review from dtrifiro July 1, 2024 20:14
@prashantgupta24
🐛 fix assert
afe4de5 
Signed-off-by: Prashant Gupta <[email protected]>
@dtrifiro
Copy link
Contributor

dtrifiro commented Jul 2, 2024

CI will fail until 0.5.1 is released

@prashantgupta24
Copy link
Contributor Author

CI will fail until 0.5.1 is released

Yes but the bug is not related to the ci right

@dtrifiro
Copy link
Contributor

dtrifiro commented Jul 2, 2024

See #28: this will immediately stop the adapter if one of the tasks fails

@dtrifiro
Copy link
Contributor

dtrifiro commented Jul 2, 2024 •
edited
Loading

Regarding this PR: I included this in #30 (474cb80), while modifying it to make sure this works with the current (and previous) vLLM versions

@prashantgupta24 prashantgupta24 deleted the fix-stat-logger branch September 3, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtrifiro dtrifiro Awaiting requested review from dtrifiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prashantgupta24 @dtrifiro