pyproject: Pin OpenTelemetry versions#106
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
=======================================
Coverage 55.98% 55.98%
=======================================
Files 24 24
Lines 1486 1486
Branches 268 268
=======================================
Hits 832 832
Misses 579 579
Partials 75 75 ☔ View full report in Codecov by Sentry. |
njhill
approved these changes
Aug 22, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR pins the major and minor versions of the OpenTelemetry packages to avoid potential issues with version mismatches.
This is a follow-up to vllm-project/vllm#7266
How Has This Been Tested?
I build the project
python -m build && pip install dist/*whland manually verified that the OTel package versions fall within the pinned range by runningpip list | grep opentelemetryMerge criteria: