Repository navigation
fix(dashboard): wrong path for consolelink in downstream - #933
Merged
Merged
Conversation
zdtsw
requested review from
VaishnaviHire and
lucferbux
and removed request for
asanzgom and
gmfrasca
March 22, 2024 12:33
ykaliuta
approved these changes
Mar 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux, ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
New changes are detected. LGTM label has been removed. |
zdtsw
enabled auto-merge (squash)
March 22, 2024 15:41
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Mar 25, 2024
…a-services#933) Signed-off-by: Wen Zhou <wenzhou@redhat.com>
zdtsw
referenced
this pull request
in red-hat-data-services/rhods-operator
Mar 25, 2024
* chore: move testing fixtures to fixtures directory (#906) This change aims to enhance the readability of our test suite. It brings `/crds` and `/templates` into `/fixtures` and moves more helper functions out into dedicated files. * feat(build): adds gci to go fmt target (#925) This update incorporates the `gci` tool into the `make fmt` command, aiming to improve the formatting of Go files and ensure that imports adhere to our established conventions. Unfortunately, due to how `.golangci.yml` is defined, we are not able to just use `--disable-all --enable=gci` flags. This yields an error as we use `enable-all` and `disable` in the config file for linter. To address this, the `golangci-lint` configuration is dynamically adjusted using the `yq` tool, which is now included in our toolchain. This process creates a temporary configuration file specifically for `golangci-lint` execution, ensuring `gci`'s integration without altering the primary linting setup. Furthermore, the generated temporary file is added to the `CLEANFILES` list, ensuring its removal when calling `make clean`, maintaining a clean build environment. To prevent this temporary file from being tracked by Git, a `*.mktmp.*` pattern has been added to our `.gitignore`, safeguarding against accidental inclusion of temporary files in the repository.: ### Tidies - removes duplicate `blank` import section in `gci` config, otherwise it can add `_` imports twice * chore: splits feature tests to separate files (#924) As the number of test cases (grouped as `Describe`) started to grow, we can split a single file into several groups per functionality. Follow-up for #906. * fix(dashboard): do not set owner on CR (#923) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * (fix): Description patch during make bundle (#926) * feat(DW): prepare CF,ray,kueue for GA (#929) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(dashboard): wrong path for consolelink in downstream (#933) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * docs: remove modelregistry and update default application NS Signed-off-by: Zhou, Wen <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> Co-authored-by: Cameron Garrison <cgarriso@redhat.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> Co-authored-by: Ajay Jaganathan <36824134+AjayJagan@users.noreply.github.com>
Closed
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Apr 23, 2024
…a-services#933) Signed-off-by: Wen Zhou <wenzhou@redhat.com>
robotmaxtron
pushed a commit
to robotmaxtron/opendatahub-operator
that referenced
this pull request
Sep 17, 2025
…ahub-io#232) * chore: move testing fixtures to fixtures directory (opendatahub-io#906) This change aims to enhance the readability of our test suite. It brings `/crds` and `/templates` into `/fixtures` and moves more helper functions out into dedicated files. * feat(build): adds gci to go fmt target (opendatahub-io#925) This update incorporates the `gci` tool into the `make fmt` command, aiming to improve the formatting of Go files and ensure that imports adhere to our established conventions. Unfortunately, due to how `.golangci.yml` is defined, we are not able to just use `--disable-all --enable=gci` flags. This yields an error as we use `enable-all` and `disable` in the config file for linter. To address this, the `golangci-lint` configuration is dynamically adjusted using the `yq` tool, which is now included in our toolchain. This process creates a temporary configuration file specifically for `golangci-lint` execution, ensuring `gci`'s integration without altering the primary linting setup. Furthermore, the generated temporary file is added to the `CLEANFILES` list, ensuring its removal when calling `make clean`, maintaining a clean build environment. To prevent this temporary file from being tracked by Git, a `*.mktmp.*` pattern has been added to our `.gitignore`, safeguarding against accidental inclusion of temporary files in the repository.: ### Tidies - removes duplicate `blank` import section in `gci` config, otherwise it can add `_` imports twice * chore: splits feature tests to separate files (opendatahub-io#924) As the number of test cases (grouped as `Describe`) started to grow, we can split a single file into several groups per functionality. Follow-up for opendatahub-io#906. * fix(dashboard): do not set owner on CR (opendatahub-io#923) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * (fix): Description patch during make bundle (opendatahub-io#926) * feat(DW): prepare CF,ray,kueue for GA (opendatahub-io#929) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(dashboard): wrong path for consolelink in downstream (opendatahub-io#933) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * docs: remove modelregistry and update default application NS Signed-off-by: Zhou, Wen <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> Co-authored-by: Cameron Garrison <cgarriso@redhat.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> Co-authored-by: Ajay Jaganathan <36824134+AjayJagan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as far of https://issues.redhat.com/browse/RHOAIENG-3760, changes break downstream,
this is a fix for that
Description
How Has This Been Tested?
Merge criteria: