Skip to content

Added get, list, and watch to storageclasses - #1839

Merged
openshift-merge-bot[bot] merged 1 commit into
opendatahub-io:mainfrom
rsun19:patch-1
Apr 9, 2025
Merged

openshift-merge-bot[bot] merged 1 commit into
opendatahub-io:mainfrom
rsun19:patch-1

Conversation

@rsun19

@rsun19 rsun19 commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

Description

Added get, watch, and list to admin users so they can patch effectively, and get access to storage classes in the table.

https://issues.redhat.com/browse/RHOAIENG-22907

How Has This Been Tested?

n/a

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@rsun19

rsun19 commented Apr 8, 2025

Copy link
Copy Markdown
Contributor Author

CC @Gkrumbach07

@rsun19

rsun19 commented Apr 9, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@codecov

codecov Bot commented Apr 9, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.87%. Comparing base (782709a) to head (52be729).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1839   +/-   ##
=======================================
  Coverage   25.87%   25.87%           
=======================================
  Files         173      173           
  Lines       12009    12009           
=======================================
  Hits         3107     3107           
  Misses       8607     8607           
  Partials      295      295           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StevenTobin

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Apr 9, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: StevenTobin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Apr 9, 2025
@openshift-merge-bot
openshift-merge-bot Bot merged commit de9f020 into opendatahub-io:main Apr 9, 2025
@github-project-automation github-project-automation Bot moved this from Todo to Done in ODH Platform Planning Apr 9, 2025
@lburgazzoli

Copy link
Copy Markdown
Member

/cherrypick rhoai

@openshift-cherrypick-robot

Copy link
Copy Markdown

@lburgazzoli: new pull request created: #1895

Details

In response to this:

/cherrypick rhoai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants