Repository navigation
DSC permissions should be cluster permissions - #1612
Merged
openshift-merge-bot[bot] merged 2 commits intoFeb 5, 2025
Merged
openshift-merge-bot[bot] merged 2 commits into
openshift-merge-bot[bot] merged 2 commits into
Conversation
Member
|
/approve |
Member
|
/hold |
Member
|
@StevenTobin I just put a hold as I didnot read the comment about adding a patch. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1612 +/- ##
=======================================
Coverage 20.35% 20.35%
=======================================
Files 163 163
Lines 11096 11096
=======================================
Hits 2259 2259
Misses 8597 8597
Partials 240 240 ☔ View full report in Codecov by Sentry. |
ugiordan
approved these changes
Feb 5, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AjayJagan, ugiordan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
StevenTobin
force-pushed
the
Fix_DSC_permissions
branch
from
February 5, 2025 09:50
c458f24 to
285f481
Compare
Member
|
/lgtm |
MarianMacik
pushed a commit
to MarianMacik/opendatahub-operator
that referenced
this pull request
May 23, 2025
* DSC permissions should be cluster permissions * add patch permissions for DSC
openshift-merge-bot Bot
pushed a commit
that referenced
this pull request
May 26, 2025
* (fix): Typo in clusterrole for admin users (#1512) * Clarify and update permissions (#1538) * Add readme to explain values of permissions * NIM Accounts are namespaced resources * Update permissions to fulfill doc design * Based on feedback, less hard-fast ruling wording in the README * Setup admin permissions for hardware profiles (#1573) * DSC permissions should be cluster permissions (#1612) * DSC permissions should be cluster permissions * add patch permissions for DSC --------- Co-authored-by: Ajay Jaganathan <36824134+AjayJagan@users.noreply.github.com> Co-authored-by: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com> Co-authored-by: Dipanshu Gupta <97534722+dpanshug@users.noreply.github.com> Co-authored-by: Steven Tobin <stobin@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The permissions added to admins should be a cluster permissions since the DSC is a cluster resource not namespaced.
How Has This Been Tested?
Screenshot or short clip
Merge criteria