Skip to content

[Sync] changes from main - #1607

Merged
openshift-merge-bot[bot] merged 2 commits into
opendatahub-io:rhoaifrom
zdtsw-forking:sync_odh_6
Feb 4, 2025
Merged

[Sync] changes from main#1607
openshift-merge-bot[bot] merged 2 commits into
opendatahub-io:rhoaifrom
zdtsw-forking:sync_odh_6

Conversation

@zdtsw

@zdtsw zdtsw commented Feb 3, 2025

Copy link
Copy Markdown
Member

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@lburgazzoli @zdtsw
fix: use Monitoring.Spec.Namespace instead of the DSCI one (opendatah…
b86a2ca 
…ub-io#1540)

This reduce the direct dependency from Monitoring to DSCI

(cherry picked from commit 5321b8c)
@lburgazzoli @zdtsw
chore: cleanup Monitoring's initialize action (opendatahub-io#1542)
a249903 
The Monitoring controller is initialized only when the platform is
managed, hence there's no need to conditionally add manifests

(cherry picked from commit 21eba1b)
@zdtsw
zdtsw requested a review from VaishnaviHire February 3, 2025 14:10
@openshift-ci
openshift-ci Bot requested a review from CFSNM February 3, 2025 14:10
@zdtsw zdtsw added the rhoai label Feb 3, 2025
@codecov

codecov Bot commented Feb 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 20.02%. Comparing base (038bbf5) to head (a249903).
Report is 3 commits behind head on rhoai.

Files with missing lines Patch % Lines
...rvices/monitoring/monitoring_controller_actions.go 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            rhoai    #1607      +/-   ##
==========================================
+ Coverage   20.01%   20.02%   +0.01%     
==========================================
  Files         160      160              
  Lines       10982    10976       -6     
==========================================
  Hits         2198     2198              
+ Misses       8549     8543       -6     
  Partials      235      235

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-ci openshift-ci Bot added the lgtm label Feb 3, 2025
@openshift-ci

openshift-ci Bot commented Feb 3, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CFSNM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Feb 3, 2025
@zdtsw

zdtsw commented Feb 4, 2025

Copy link
Copy Markdown
Member Author

/test opendatahub-operator-e2e

@openshift-merge-bot
openshift-merge-bot Bot merged commit dd44dcd into opendatahub-io:rhoai Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VaishnaviHire VaishnaviHire Awaiting requested review from VaishnaviHire
1 more reviewer
@CFSNM CFSNM CFSNM approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@CFSNM CFSNM

Labels

approved lgtm rhoai

Projects

ODH Platform Planning
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zdtsw @CFSNM @lburgazzoli