Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ensures tests are run on push #1236

Conversation

bartoszmajsak
Copy link
Contributor

@bartoszmajsak bartoszmajsak commented Sep 14, 2024

Description

Unit tests job is currently only executed on PRs, leaving pushes on e.g. incubation branch untested. This can lead to issues like the one described in #1235

This PR enables GH Action to be run also for push events.

How Has This Been Tested?

You can use act to test GH Actions locally instead of running them on your fork.

act "on: push" -j unit-test -P ubuntu-latest=ghcr.io/catthehacker/ubuntu:act-latest

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Unit tests job is currently only executed on PRs, leaving pushes on e.g.
incubation branch untested. This can lead to issues like the one
described in opendatahub-io#1235

This PR enables GH Action to be run also for push events.
@zdtsw
Copy link
Member

zdtsw commented Sep 14, 2024

Put a "on hold" label, so we can have some disucssion before merge this change.
Mostly, this involves work process of how PR should be merged, if we enforce all branch up-to-date before PR merge, or how to prevent stable branch gets merged in.

@zdtsw
Copy link
Member

zdtsw commented Sep 16, 2024

this is also related to "#1221 (comment)"

@ykaliuta
Copy link
Contributor

Put a "on hold" label, so we can have some disucssion before merge this change. Mostly, this involves work process of how PR should be merged, if we enforce all branch up-to-date before PR merge, or how to prevent stable branch gets merged in.

Should the workflow just filter by branch?

Copy link

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5d51806 into opendatahub-io:incubation Sep 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants