Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade go from 1.20 to 1.21 #1064

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Jun 18, 2024

ref: https://issues.redhat.com/browse/RHOAIENG-8296
Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request contains description of the issue
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request

Description

JIRA issue:

How Has This Been Tested?

Screenshot or short clip:

Merge criteria:

  • Have a meaningful commit messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw zdtsw requested review from grdryn and ykaliuta and removed request for MarianMacik and asanzgom June 18, 2024 11:52
Copy link
Member

@grdryn grdryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm thanks @zdtsw! :)

Copy link

openshift-ci bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn, ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw merged commit e9b6211 into opendatahub-io:incubation Jun 18, 2024
6 of 8 checks passed
zdtsw added a commit to zdtsw-forking/rhods-operator that referenced this pull request Jun 19, 2024
openshift-merge-bot bot pushed a commit to red-hat-data-services/rhods-operator that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants