kserve: get rid of extra enabled check for setupKserveConfig()

To avoid linter report: components/kserve/kserve.go:97:1: cyclomatic complexity 31 of func `(*Kserve).ReconcileComponent` is high (> 30) (gocyclo) move setupKserveConfig() call under "if enabled" branch below. Signed-off-by: Yauheni Kaliuta <[email protected]>
opendatahub-io · May 23, 2024 · 2fbf8ba · 2fbf8ba
1 parent 4f2519e
commit 2fbf8ba
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/components/kserve/kserve.go b/components/kserve/kserve.go
@@ -144,14 +144,14 @@ func (k *Kserve) ReconcileComponent(ctx context.Context, cli client.Client,
 		return fmt.Errorf("failed to apply manifests from %s : %w", Path, err)
 	}
 
+	l.WithValues("Path", Path).Info("apply manifests done for kserve")
+
 	if enabled {
 		if err := k.setupKserveConfig(ctx, cli, dscispec); err != nil {
 			return err
 		}
-	}
-	l.WithValues("Path", Path).Info("apply manifests done for kserve")
-	// For odh-model-controller
-	if enabled {
+
+		// For odh-model-controller
 		if err := cluster.UpdatePodSecurityRolebinding(cli, dscispec.ApplicationsNamespace, "odh-model-controller"); err != nil {
 			return err
 		}