Skip to content

RHAIENG-4071: harden piplock-renewal workflow against credential exposure #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiridanek merged 3 commits into from
Mar 27, 2026
Merged

RHAIENG-4071: harden piplock-renewal workflow against credential exposure #3202

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa7082a
RHAIENG-4071: harden piplock-renewal workflow against credential expo…
jiridanek Mar 27, 2026
53aa765
RHAIENG-4071: fix gh pr create after explicit-URL push
jiridanek Mar 27, 2026
ca6929e
RHAIENG-4071: fix script injection via ${{ env.BRANCH }} in run blocks
jiridanek Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions .github/workflows/piplock-renewal.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
# This GitHub action is meant to update the lock files (pylock.toml)
name: Lock Files Renewal Action

permissions: {} # least-privilege: grant per-job below

on: # yamllint disable-line rule:truthy
# Triggers the workflow every Wednesday at 1am UTC
schedule:
Expand Down Expand Up @@ -48,8 +50,7 @@ jobs:
group: refresh-lock-files-${{ github.ref }}
cancel-in-progress: false
permissions:
contents: write
pull-requests: write
contents: read # checkout only; push and PR creation use the PAT
env:
BRANCH: ${{ github.event.inputs.branch || 'main' }}
INDEX_MODE: ${{ github.event.inputs.index_mode || 'auto' }}
Expand All @@ -61,8 +62,7 @@ jobs:
uses: actions/checkout@v6

@coderabbitai coderabbitai Bot Mar 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Pin actions/checkout by full commit SHA (CWE-1357: supply chain risk).

Tag @v6 can be force-pushed by upstream. Use the commit SHA to prevent silent compromise.

-        uses: actions/checkout@v6
+        uses: actions/checkout@<FULL_SHA>  # v6

As per coding guidelines: "Pin all actions by full SHA, not tags (prevent supply chain attacks)".

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/piplock-renewal.yaml at line 62, Replace the tag reference
"actions/checkout@v6" with the corresponding full commit SHA for the v6 release
to pin the action; update the workflow entry that uses actions/checkout (the
"uses: actions/checkout@v6" line) so it reads "uses:
actions/checkout@<full-commit-sha>" using the official v6 release commit hash
from the actions/checkout repository, commit the change, and verify the workflow
still runs as expected.

with:
ref: ${{ env.BRANCH }}
token: ${{ secrets.GH_ACCESS_TOKEN }}
persist-credentials: true
persist-credentials: false

- name: Configure Git
run: |
Expand All @@ -81,7 +81,7 @@ jobs:

- name: Run make refresh-lock-files
run: |
make refresh-lock-files INDEX_MODE=${{ env.INDEX_MODE }}
make refresh-lock-files INDEX_MODE="$INDEX_MODE"
env:
FORCE_LOCKFILES_UPGRADE: ${{ env.FORCE_LOCKFILES_UPGRADE }}

Expand All @@ -98,10 +98,12 @@ jobs:
BRANCH_NAME="lockfile-update-$(date +%Y%m%d-%H%M)"
git checkout -b "$BRANCH_NAME"
git commit -m "Update lock files"
git push -u origin "$BRANCH_NAME"
# https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/authenticating-as-a-github-app-installation#using-an-installation-access-token-to-authenticate-as-an-app-installation
git push -u "https://x-access-token:${GH_TOKEN}@github.com/${{ github.repository }}.git" "$BRANCH_NAME"

gh pr create \
--title "Update lock files" \
--head "$BRANCH_NAME" \
--body "$(cat <<'EOF'
Automated lock file update.

Expand All @@ -112,15 +114,14 @@ jobs:
EOF
)" \
--label "automated-lockfile-update" \
--base "${{ env.BRANCH }}"
--base "$BRANCH"

auto-merge-lockfile-prs:
# Run on auto-merge schedule or manual dispatch with 'auto-merge' operation
if: (github.event_name == 'workflow_dispatch' && github.event.inputs.operation == 'auto-merge') || (github.event_name == 'schedule' && github.event.schedule == '0 9,15 * * 1-5')
runs-on: ubuntu-latest
permissions:
contents: write
pull-requests: write
pull-requests: write # github.token is only used for PR approval (line 225)
steps:
- name: Auto-merge eligible lockfile PRs
env:
Expand Down
Loading