Skip to content

NO-JIRA: chore: fix Makefile test target to use correct ./uv script#3077

Merged
jiridanek merged 1 commit intoopendatahub-io:mainfrom
jiridanek:jd/2026/02/odh_rhoai_manifests
Mar 11, 2026
Merged

NO-JIRA: chore: fix Makefile test target to use correct ./uv script#3077
jiridanek merged 1 commit intoopendatahub-io:mainfrom
jiridanek:jd/2026/02/odh_rhoai_manifests

Conversation

@jiridanek
Copy link
Copy Markdown
Member

@jiridanek jiridanek commented Mar 10, 2026

Description

How Has This Been Tested?

Self checklist (all need to be checked):

  • Ensure that you have run make test (gmake on macOS) before asking for review
  • Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

  • Chores
    • Updated test execution configuration to use explicit path resolution in the build system.

@jiridanek jiridanek marked this pull request as ready for review March 10, 2026 14:24
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 10, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1444ee65-8c44-455f-a73e-5b74ebcf322f

📥 Commits

Reviewing files that changed from the base of the PR and between dfdb373 and 22d7ae1.

📒 Files selected for processing (1)
  • Makefile

📝 Walkthrough

Walkthrough

The Makefile's test target was updated to explicitly reference the uv command using a relative path prefix (./uv), changing from an implicit path resolution to an explicit current-directory invocation of the wrapper script.

Changes

Cohort / File(s) Summary
Build Configuration
Makefile
Modified pytest invocation in test target to use explicit relative path (./uv run pytest) instead of implicit path resolution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description consists entirely of an unfilled template with all sections and checklists left blank or unchecked, providing no substantive information about the changes, testing, or completion status. Fill in the Description section with details of the change, the How Has This Been Tested section with testing methodology, and check the completed self-checklist and merge criteria items.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title uses imperative mood ('fix') and includes a ticket reference (NO-JIRA), following the preferred format with scope (chore) and clear description of the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Branch Prefix Policy ✅ Passed PR title does not start with a branch prefix like [release-2.11] or [rhoai-2.25]; it correctly begins with NO-JIRA: ticket reference.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added size/xs and removed size/xs labels Mar 10, 2026
@github-actions github-actions Bot added the review-requested GitHub Bot creates notification on #pr-review-ai-ide-team slack channel label Mar 10, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 10, 2026

@jiridanek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 22d7ae1 link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ide-developer
Once this PR has been reviewed and has the lgtm label, please assign atheo89 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek jiridanek merged commit 8239f40 into opendatahub-io:main Mar 11, 2026
14 of 16 checks passed
@jiridanek jiridanek deleted the jd/2026/02/odh_rhoai_manifests branch March 11, 2026 09:33
jiridanek added a commit to jiridanek/notebooks that referenced this pull request Mar 13, 2026
jiridanek added a commit to red-hat-data-services/notebooks that referenced this pull request Mar 26, 2026
jiridanek added a commit to red-hat-data-services/notebooks that referenced this pull request Mar 26, 2026
jiridanek added a commit to red-hat-data-services/notebooks that referenced this pull request Mar 31, 2026
jiridanek added a commit to red-hat-data-services/notebooks that referenced this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm review-requested GitHub Bot creates notification on #pr-review-ai-ide-team slack channel size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants