RHOAIENG-38972: Allow stopping LLMInferenceService by pierDipi · Pull Request #974 · opendatahub-io/kserve

pierDipi · 2025-11-17T07:13:16Z

Allow stopping llm-d services just like any other model runtime (upstream follow up in progress)

openshift-ci · 2025-11-17T07:13:20Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2025-11-17T07:13:21Z

@pierDipi: This pull request references RHOAIENG-38579 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2025-11-17T07:13:24Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pierDipi · 2025-11-17T09:51:25Z

/test ?

openshift-ci · 2025-11-17T09:51:28Z

@pierDipi: The following commands are available to trigger required jobs:

/test e2e-graph

/test e2e-llm-inference-service

/test e2e-path-based-routing

/test e2e-predictor

/test e2e-raw

/test images

/test pr-image-mirror-kserve-agent

/test pr-image-mirror-kserve-controller

/test pr-image-mirror-kserve-router

/test pr-image-mirror-kserve-storage-initializer

Use /test all to run all jobs.

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pierDipi · 2025-11-17T09:51:35Z

/test e2e-llm-inference-service

openshift-ci-robot · 2025-11-17T13:21:24Z

@pierDipi: This pull request references RHOAIENG-38972 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pierDipi · 2025-11-17T14:27:54Z

/test e2e-llm-inference-service

pierDipi · 2025-11-18T08:39:42Z

/test e2e-llm-inference-service

pierDipi · 2025-11-18T10:03:38Z

/test e2e-llm-inference-service

pierDipi · 2025-11-18T17:06:11Z

/test e2e-llm-inference-service

pierDipi · 2025-11-18T17:27:44Z

/test e2e-llm-inference-service

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi · 2025-11-19T07:14:45Z

/test e2e-llm-inference-service

pierDipi · 2025-11-19T11:34:21Z

Unrelated

FAILED graph/test_inference_graph.py::test_ig_scenario10 - json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

/retest-required

pierDipi · 2025-11-19T13:11:53Z

Failures are unrelated

bartoszmajsak

/lgtm

openshift-ci-robot · 2025-11-24T17:59:50Z

/retest-required

Remaining retests: 0 against base HEAD f0a020c and 2 for PR HEAD ecd0ebd in total

Missed few comments

bartoszmajsak

/lgtm

openshift-ci · 2025-11-25T06:50:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bartoszmajsak, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bartoszmajsak,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bartoszmajsak · 2025-11-25T07:07:24Z

/lgtm

pierDipi · 2025-11-25T12:40:20Z

/override e2e-path-based-routing

openshift-ci · 2025-11-25T12:40:25Z

@pierDipi: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

e2e-path-based-routing

Only the following failed contexts/checkruns were expected:

CodeRabbit
ci/prow/e2e-graph
ci/prow/e2e-llm-inference-service
ci/prow/e2e-path-based-routing
ci/prow/e2e-predictor
ci/prow/e2e-raw
ci/prow/images
ci/prow/pr-image-mirror-kserve-agent
ci/prow/pr-image-mirror-kserve-controller
ci/prow/pr-image-mirror-kserve-router
ci/prow/pr-image-mirror-kserve-storage-initializer
kserve-image-build
pull-ci-opendatahub-io-kserve-master-e2e-graph
pull-ci-opendatahub-io-kserve-master-e2e-path-based-routing
pull-ci-opendatahub-io-kserve-master-e2e-predictor
pull-ci-opendatahub-io-kserve-master-e2e-raw
pull-ci-opendatahub-io-kserve-master-images
pull-ci-opendatahub-io-kserve-master-pr-image-mirror-kserve-agent
pull-ci-opendatahub-io-kserve-master-pr-image-mirror-kserve-controller
pull-ci-opendatahub-io-kserve-master-pr-image-mirror-kserve-router
pull-ci-opendatahub-io-kserve-master-pr-image-mirror-kserve-storage-initializer
pull-ci-opendatahub-io-kserve-release-v0.15-e2e-llm-inference-service
push
test-llmisvc
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override e2e-path-based-routing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pierDipi · 2025-11-25T12:40:26Z

/override e2e-predictor

openshift-ci · 2025-11-25T12:40:31Z

@pierDipi: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

e2e-predictor

Only the following failed contexts/checkruns were expected:

CodeRabbit
ci/prow/e2e-graph
ci/prow/e2e-llm-inference-service
ci/prow/e2e-path-based-routing
ci/prow/e2e-predictor
ci/prow/e2e-raw
ci/prow/images
ci/prow/pr-image-mirror-kserve-agent
ci/prow/pr-image-mirror-kserve-controller
ci/prow/pr-image-mirror-kserve-router
ci/prow/pr-image-mirror-kserve-storage-initializer
kserve-image-build
pull-ci-opendatahub-io-kserve-master-e2e-graph
pull-ci-opendatahub-io-kserve-master-e2e-path-based-routing
pull-ci-opendatahub-io-kserve-master-e2e-predictor
pull-ci-opendatahub-io-kserve-master-e2e-raw
pull-ci-opendatahub-io-kserve-master-images
pull-ci-opendatahub-io-kserve-master-pr-image-mirror-kserve-agent
pull-ci-opendatahub-io-kserve-master-pr-image-mirror-kserve-controller
pull-ci-opendatahub-io-kserve-master-pr-image-mirror-kserve-router
pull-ci-opendatahub-io-kserve-master-pr-image-mirror-kserve-storage-initializer
pull-ci-opendatahub-io-kserve-release-v0.15-e2e-llm-inference-service
push
test-llmisvc
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override e2e-predictor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pierDipi · 2025-11-25T13:09:26Z

/override ci/prow/e2e-path-based-routing

openshift-ci · 2025-11-25T13:09:33Z

@pierDipi: Overrode contexts on behalf of pierDipi: ci/prow/e2e-path-based-routing

Details

In response to this:

/override ci/prow/e2e-path-based-routing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pierDipi · 2025-11-25T13:09:35Z

/override ci/prow/e2e-predictor

openshift-ci · 2025-11-25T13:09:41Z

@pierDipi: Overrode contexts on behalf of pierDipi: ci/prow/e2e-predictor

Details

In response to this:

/override ci/prow/e2e-predictor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2025-11-25T16:54:19Z

@pierDipi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-graph	`ecd0ebd`	link	unknown	`/test e2e-graph`
ci/prow/e2e-predictor	`ecd0ebd`	link	unknown	`/test e2e-predictor`
ci/prow/e2e-path-based-routing	`ecd0ebd`	link	unknown	`/test e2e-path-based-routing`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

github-project-automation Bot moved this to New/Backlog in ODH Model Serving Planning Nov 17, 2025

github-project-automation Bot added this to ODH Model Serving Planning Nov 17, 2025

openshift-ci-robot added the jira/valid-reference label Nov 17, 2025

openshift-ci Bot added the do-not-merge/work-in-progress label Nov 17, 2025

openshift-ci Bot added the approved label Nov 17, 2025

pierDipi force-pushed the llmisvc-stop branch 2 times, most recently from 3ede3e9 to 5e2ea52 Compare November 17, 2025 08:58

pierDipi changed the title ~~RHOAIENG-38579: Allow stopping LLMInferenceService~~ RHOAIENG-38972: Allow stopping LLMInferenceService Nov 17, 2025

pierDipi force-pushed the llmisvc-stop branch from 5e2ea52 to 5ca9656 Compare November 17, 2025 14:27

pierDipi force-pushed the llmisvc-stop branch from 5ca9656 to 89793c9 Compare November 18, 2025 08:39

pierDipi force-pushed the llmisvc-stop branch 2 times, most recently from 4f2a847 to ef15f90 Compare November 18, 2025 10:03

pierDipi force-pushed the llmisvc-stop branch from ef15f90 to c373a80 Compare November 18, 2025 16:50

pierDipi force-pushed the llmisvc-stop branch from c373a80 to a2fa2f2 Compare November 18, 2025 17:23

Allow stopping LLMInferenceService

ecd0ebd

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

pierDipi force-pushed the llmisvc-stop branch from a2fa2f2 to ecd0ebd Compare November 19, 2025 07:14

pierDipi marked this pull request as ready for review November 19, 2025 10:24

pierDipi requested review from bartoszmajsak and hdefazio November 19, 2025 11:09

pierDipi requested a review from Jooho November 20, 2025 15:11

brettmthompson reviewed Nov 24, 2025

View reviewed changes

Comment thread pkg/controller/llmisvc/monitoring.go

bartoszmajsak previously approved these changes Nov 24, 2025

View reviewed changes

openshift-ci Bot assigned bartoszmajsak Nov 24, 2025

openshift-ci Bot added the lgtm label Nov 24, 2025

bartoszmajsak removed the lgtm label Nov 24, 2025

pierDipi requested review from bartoszmajsak and brettmthompson November 25, 2025 06:04

bartoszmajsak approved these changes Nov 25, 2025

View reviewed changes

openshift-ci Bot added the lgtm label Nov 25, 2025

openshift-merge-bot Bot merged commit 64fe282 into opendatahub-io:release-v0.15 Nov 25, 2025
35 checks passed

github-project-automation Bot moved this from New/Backlog to Done in ODH Model Serving Planning Nov 25, 2025

KillianGolds pushed a commit to KillianGolds/kserve-fork that referenced this pull request Nov 28, 2025

Allow stopping LLMInferenceService (opendatahub-io#974)

ad36904

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Conversation

pierDipi commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Nov 17, 2025

Uh oh!

openshift-ci-robot commented Nov 17, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

pierDipi commented Nov 17, 2025

Uh oh!

openshift-ci Bot commented Nov 17, 2025

Uh oh!

pierDipi commented Nov 17, 2025

Uh oh!

openshift-ci-robot commented Nov 17, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pierDipi commented Nov 17, 2025

Uh oh!

pierDipi commented Nov 18, 2025

Uh oh!

pierDipi commented Nov 18, 2025

Uh oh!

pierDipi commented Nov 18, 2025

Uh oh!

pierDipi commented Nov 18, 2025

Uh oh!

pierDipi commented Nov 19, 2025

Uh oh!

pierDipi commented Nov 19, 2025

Uh oh!

pierDipi commented Nov 19, 2025

Uh oh!

Uh oh!

bartoszmajsak left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Nov 24, 2025

Uh oh!

bartoszmajsak left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Nov 25, 2025

Uh oh!

bartoszmajsak commented Nov 25, 2025

Uh oh!

pierDipi commented Nov 25, 2025

Uh oh!

openshift-ci Bot commented Nov 25, 2025

Uh oh!

pierDipi commented Nov 25, 2025

Uh oh!

openshift-ci Bot commented Nov 25, 2025

Uh oh!

pierDipi commented Nov 25, 2025

Uh oh!

openshift-ci Bot commented Nov 25, 2025

Uh oh!

pierDipi commented Nov 25, 2025

Uh oh!

openshift-ci Bot commented Nov 25, 2025

Uh oh!

Uh oh!

openshift-ci Bot commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pierDipi commented Nov 17, 2025 •

edited

Loading

openshift-ci-robot commented Nov 17, 2025 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Nov 17, 2025 •

edited

Loading

openshift-ci-robot commented Nov 17, 2025 •

edited by openshift-ci Bot

Loading

bartoszmajsak left a comment •

edited

Loading