Skip to content

test data files testExifOrientation*#1271

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
sturkmen72:metadata
Jul 23, 2025
Merged

test data files testExifOrientation*#1271
asmorkalov merged 1 commit intoopencv:4.xfrom
sturkmen72:metadata

Conversation

@sturkmen72
Copy link
Contributor

merge with opencv/opencv#27503

@asmorkalov
Copy link
Contributor

@sturkmen72 Why do you need *.png update? The original and new images look similar.

@asmorkalov asmorkalov self-requested a review July 22, 2025 08:40
@sturkmen72
Copy link
Contributor Author

updated files has alpha channel.
to make the test code more meaningful

    if (m_img.channels() == 3)
    {
        Vec3b vec;

        //Checking the first quadrant (with supposed red)
        vec = m_img.at<Vec3b>(2, 2); //some point inside the square
        EXPECT_LE(vec.val[0], colorThresholdLow);
        EXPECT_LE(vec.val[1], colorThresholdLow);
        EXPECT_GE(vec.val[2], colorThresholdHigh);

        //Checking the second quadrant (with supposed green)
        vec = m_img.at<Vec3b>(2, 7);  //some point inside the square
        EXPECT_LE(vec.val[0], colorThresholdLow);
        EXPECT_GE(vec.val[1], colorThresholdHigh);
        EXPECT_LE(vec.val[2], colorThresholdLow);

        //Checking the third quadrant (with supposed blue)
        vec = m_img.at<Vec3b>(7, 2);  //some point inside the square
        EXPECT_GE(vec.val[0], colorThresholdHigh);
        EXPECT_LE(vec.val[1], colorThresholdLow);
        EXPECT_LE(vec.val[2], colorThresholdLow);
    }
    else
    {
        Vec4b vec;

        //Checking the first quadrant (with supposed red)
        vec = m_img.at<Vec4b>(2, 2); //some point inside the square
        EXPECT_LE(vec.val[0], colorThresholdLow);
        EXPECT_LE(vec.val[1], colorThresholdLow);
        EXPECT_GE(vec.val[2], colorThresholdHigh);

@sturkmen72
Copy link
Contributor Author

i added webp files with alpha channel

@sturkmen72
Copy link
Contributor Author

@asmorkalov note: i think no need to restart CI related last commit.

@asmorkalov asmorkalov merged commit b3a4020 into opencv:4.x Jul 23, 2025
asmorkalov pushed a commit to opencv/opencv that referenced this pull request Jul 23, 2025
[GSOC 2025] PNG&WebP Metadata Reading Writing Improvements #27503

Merge with opencv/opencv_extra#1271

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
@sturkmen72 sturkmen72 deleted the metadata branch July 23, 2025 13:09
@asmorkalov asmorkalov mentioned this pull request Jul 28, 2025
D00E pushed a commit to D00E/opencv that referenced this pull request Sep 19, 2025
[GSOC 2025] PNG&WebP Metadata Reading Writing Improvements opencv#27503

Merge with opencv/opencv_extra#1271

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants