Extended perf tests for warpPerspective to cover channels too#26054
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Aug 23, 2024
Merged
Extended perf tests for warpPerspective to cover channels too#26054asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov merged 1 commit intoopencv:4.xfrom
Conversation
mshabunin
reviewed
Aug 21, 2024
| #ifdef __ANDROID__ | ||
| SANITY_CHECK(dst, interType==INTER_LINEAR? 5 : 10); | ||
| #else | ||
| SANITY_CHECK(dst, 1); |
Contributor
There was a problem hiding this comment.
Maybe SANITY_CHECK_NOTHING()? We're trying to deprecate accuracy checks in perf tests for some time (https://github.com/opencv/opencv/wiki/HowToWritePerfTests#simple-regression-check).
Contributor
Author
There was a problem hiding this comment.
Let's presume the checks, where we have it. No check for new code.
mshabunin
approved these changes
Aug 23, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removed Android branch in tests. It's not relevant any more.
Extra: opencv/opencv_extra#1204
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.