curvefs/client: remove unused setting fuseMaxSize #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziy1-Tan
changed the title
|
cicheck |
Ziy1-Tan
force-pushed
the
patch/cache_conf
branch
from
8a2d3c1 to
0533eab
Compare
|
cicheck |
2 similar comments
|
cicheck |
|
cicheck |
aspirer
reviewed
May 23, 2023
| fsCacheManager_->DataCacheByteDec(length); | ||
| if (s3Metric_.get() != nullptr) { | ||
| CollectMetrics(&s3Metric_->adaptorWrite, ret, start); | ||
| s3Metric_->writeSize.set_value(length); | ||
| } | ||
| VLOG(6) << "write end inodeId:" << inodeId << ",ret:" << ret | ||
| << ", pendingReq_ is: " << pendingReq_; | ||
| VLOG(6) << "write end inodeId:" << inodeId << ",ret:" << ret; |
There was a problem hiding this comment.
VLOG(6) << "write end inodeId: " << inodeId << ", ret: " << ret; add some whitespace
Signed-off-by: Ziy1-Tan <[email protected]>
Ziy1-Tan
force-pushed
the
patch/cache_conf
branch
from
0533eab to
ad35d10
Compare
Ziy1-Tan
changed the title
|
cicheck |
1 similar comment
|
cicheck |
wuhongsong
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Depends on: #2492
Problem Summary: after that, fuseMaxSize is not needed anymore
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List