Move release guidance to repo agents file - #11
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR consolidates all SDK/CLI release guidance into a new
Confidence Score: 4/5Documentation-only change with no code or automation modifications; safe to merge, but some guidance content is dropped without a replacement location. The core release workflow is accurately captured in AGENTS.md and no automation is touched. The concern is that the deleted SKILL.md carried adapter security rules and a review checklist that do not appear anywhere in the new file, and the major-version agent prompt is reduced to two sentences with no structured task list or do-not-publish safeguards. These are guidance gaps rather than broken functionality, but they could affect how a future agent handles a major release or SDK integration review. skills/email-sdk/SKILL.md (deleted) and docs/release/major-version-agent-prompt.md (deleted) are worth a second look to confirm their non-release content is intentionally dropped or lives elsewhere. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Developer makes SDK/CLI change] --> B[bun run changeset]
B --> C[Commit .changeset/*.md with code PR]
C --> D[Merge feature PR to main]
D --> E{Pending changesets on main?}
E -- Yes --> F[CI opens 'Version packages' PR]
E -- No --> G[Wait for more changesets]
F --> H{Major version?}
H -- Yes --> I[Migration notes documented in PR?]
I -- No --> J[Do NOT merge]
I -- Yes --> K[Merge 'Version packages' PR]
H -- No --> K
K --> L[Bump version + update changelog]
L --> M[Publish to npm via GitHub-hosted runner]
M --> N[Create GitHub release/tag]
|
| ## Major Versions | ||
|
|
||
| Major versions need migration notes in the PR that introduces the breaking change. Include before/after examples for changed imports, options, CLI flags, adapter behavior, or public types. | ||
|
|
||
| Do not merge a `Version packages` PR for a major version unless the migration path is documented. |
There was a problem hiding this comment.
Migration notes scoped to PR only, not committed as files
The old workflow required a committed file at docs/release/migrations/vX.md (enforced in both the SKILL.md and docs/release/migrations/README.md). This new wording — "migration notes in the PR that introduces the breaking change" — means the notes live only in the PR description, which becomes hard to discover once the PR is closed/merged.
Consider clarifying whether a committed file is still expected (e.g. in docs/release/migrations/ or inline in CHANGELOG), or explicitly note that the PR description is the intended permanent home. As written, a future maintainer or agent could easily miss migration guidance for a past major version.
Confidence this is an issue: 4/5
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
Validation