fix(web): keep settings inputs focused during IME composition - #233
Merged
Conversation
Enter while an IME is composing used to blur and commit a half-finished character. Settings DraftInput fields now ignore that key until composition finishes. Adapted from pingdotgg#10262.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
vouch:trusted
CI typecheck failed because the test treated React's nativeEvent as a full KeyboardEvent. The helper now takes only the composition fields it reads.
Greptile SummaryThe IME Enter guard prevents settings inputs from committing or losing focus while an IME candidate is being confirmed. No new issues were identified. Confidence Score: 5/5Safe to merge. There are no outstanding findings. Reviews (2): Last reviewed commit: "Merge branch 'main' into fix/web-ime-com..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
useCommitOnBlurno longer treats Enter as commit while an IME is composing (isComposingor keyCode 229). SettingsDraftInputfields keep focus until composition finishes.Why
Confirming a CJK candidate with Enter was also submitting the half-composed value and stealing focus. BotPromptComposer already ignored composing Enter. Settings inputs did not.
Adapted from pingdotgg/t3code#10262.
UI Changes
No layout change. Callers: Settings provider instance names, portability paths, and other
DraftInputfields.Checklist
Verification
vp test run apps/web/src/hooks/useCommitOnBlur.test.tsImplemented and verified by Grok 4.6 High in Grok Build via Orca.