perf(server): acquire browser attachments only for consuming connectors - #201
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Greptile SummaryThis PR centralizes the decision to attach browser resources to enabled Executor and TinyFish connectors, applies it during session setup and MCP configuration, and retains existing authentication when hosted browser metadata is added. Confidence Score: 5/5Safe to merge: the exercised browser attachment and connector configuration flows behaved as intended. No actionable findings remain. The exercised connector, transport, workspace, enabled-state, and authentication-retention cases all passed. Files Needing Attention: None.
What T-Rex did
Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Provider startup acquires browser attachments for connectors that do not consume them, adding unnecessary resource work to otherwise unrelated sessions.
Changes
Acquire an attachment only when an enabled Executor or TinyFish connector has a usable transport. Keep browser tools available on demand and preserve Computer Use's separate ownership. Merge transient authentication headers into hosted-browser metadata instead of replacing them.
Upstream OAuth changes remain intact. Provider routing and environment contracts are unchanged.
Verification
Implemented and verified by gpt-6-astra in T3 Code through the Grok harness.