Skip to content

perf(server): acquire browser attachments only for consuming connectors - #201

Merged
leoisadev1 merged 2 commits into
mainfrom
perf/connector-browser-acquisition
Sep 8, 2026
Merged

perf(server): acquire browser attachments only for consuming connectors#201
leoisadev1 merged 2 commits into
mainfrom
perf/connector-browser-acquisition

Conversation

@leoisadev1

Copy link
Copy Markdown
Member

Problem

Provider startup acquires browser attachments for connectors that do not consume them, adding unnecessary resource work to otherwise unrelated sessions.

Changes

Acquire an attachment only when an enabled Executor or TinyFish connector has a usable transport. Keep browser tools available on demand and preserve Computer Use's separate ownership. Merge transient authentication headers into hosted-browser metadata instead of replacing them.

Upstream OAuth changes remain intact. Provider routing and environment contracts are unchanged.

Verification

  • Parent verification passed 116 tests across session resources, agent controller, MCP configuration, browser tools, and server startup.
  • Fixtures cover local and hosted workspaces, stdio/URL transports, disabled and unrelated connectors, on-demand tools, Computer Use cleanup, transient authentication, and existing provider routing.
  • Targeted lint, formatting, focused TypeScript checking, and diff checks passed. Configured Effect diagnostics remain a CI gate.
  • Codex and Kimi retain the Mastra controller; Claude, Grok, and OpenCode retain the adapter bridge. Existing OpenCode Go selection remains covered.
  • No live providers, paid calls, or client UI changes. These are resource-lifetime and routing tests, not an end-to-end provider-startup benchmark.

Implemented and verified by gpt-6-astra in T3 Code through the Grok harness.

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
akeru-bot-landing Skipped Skipped Sep 8, 2026 7:56pm UTC

Request Review

@github-actions github-actions Bot added type:provider Agent provider contribution. area:connectors Plugin and MCP connector runtime. vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M labels Sep 8, 2026
@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown

Greptile Summary

This PR centralizes the decision to attach browser resources to enabled Executor and TinyFish connectors, applies it during session setup and MCP configuration, and retains existing authentication when hosted browser metadata is added.

Confidence Score: 5/5

Safe to merge: the exercised browser attachment and connector configuration flows behaved as intended.

No actionable findings remain. The exercised connector, transport, workspace, enabled-state, and authentication-retention cases all passed.

Files Needing Attention: None.

T-Rex T-Rex Logs

What T-Rex did

  • T-Rex exercised browser attachment acquisition across enabled and disabled Executor, TinyFish, and unrelated connectors using local and hosted workspaces with both stdio and URL transports.
  • T-Rex validated that attachments are acquired only when the consuming connector can handle them, and confirmed that hosted URL connectors retain the existing Authorization header along with browser metadata.
  • T-Rex ran the temporary integration tests (11/11) and the existing focused tests (93/93); all tests passed.
  • T-Rex confirmed that no tracked files were modified during this work.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile

@leoisadev1
leoisadev1 merged commit 1b09cfa into main Sep 8, 2026
11 checks passed
@leoisadev1
leoisadev1 deleted the perf/connector-browser-acquisition branch September 8, 2026 20:17
@github-actions github-actions Bot mentioned this pull request Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:connectors Plugin and MCP connector runtime. size:M type:provider Agent provider contribution. vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant