perf(protocol): make raw event retention opt-in - #198
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummarySummary
Confidence Score: 5/5Safe to merge: no concrete defects were found in the changed protocol-observation behavior. The final finding set is empty. Focused ACP and Codex tests passed for disabled observation, bounded retention, unbounded replay, callback dispatch, request replies, stream completion, and scope cleanup. Files Needing Attention: No files need follow-up changes.
What T-Rex did
Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The ACP and Codex app-server transports retain raw protocol events even when callers consume only callbacks. An unread observation stream can therefore retain the whole session without helping required protocol work.
Changes
Disable optional raw observation by default. Expose bounded sliding buffers and an explicit
"unbounded"compatibility option through client and agent constructors. Keep notification callbacks, request handlers, correlated replies, and connection shutdown independent of observation retention. Document the new defaults and migration option.This affects the transport packages, not the Mastra Codex/Kimi turn path. Repository runtime consumers do not read the raw streams. External consumers needing legacy lossless observation must opt in to
"unbounded".Verification
Implemented and verified by gpt-6-astra in T3 Code through the Grok harness.