Skip to content

fix(settings): remove obsolete thread controls - #150

Merged
leoisadev1 merged 6 commits into
mainfrom
t3code/remove-outdated-thread-settings
Sep 3, 2026
Merged

fix(settings): remove obsolete thread controls#150
leoisadev1 merged 6 commits into
mainfrom
t3code/remove-outdated-thread-settings

Conversation

@leoisadev1

Copy link
Copy Markdown
Member

What Changed

  • Removed auto-settle preferences and inactivity or pull-request-driven settlement across web, desktop, and mobile.
  • Removed automatic conversation naming from first-turn generation, provider metadata, and bot or group prompt seeds.
  • Removed bot-irrelevant thread controls from General settings and renamed the remaining model control to Fallback model.
  • Updated contracts, focused tests, and user documentation for manual-only settlement.

Why

Akeru uses a bot roster. The inherited thread automation and General settings exposed a T3 Code workflow that the bot interface does not use.

UI Changes

Before

General settings before

After

General settings after

Testing

  • vp test run on 10 focused files: 345 tests passed.
  • Targeted typechecks passed for contracts, server, web, mobile, and desktop.
  • Targeted lint passed with one existing SettingsPanels.tsx inline-schema warning.
  • Browser verification confirmed the retired General settings are absent.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • This PR does not add a plugin or provider
  • I included before/after screenshots for the UI changes
  • This PR has no animation or interaction change that needs a video

Model: gpt-5.6-sol
Harness: Codex in T3 Code

Remove auto-settle preferences and automatic conversation naming from the bot-first workflow. Hide legacy thread controls from General settings while preserving active compatibility paths.
@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
akeru-bot-landing Building Building Preview Sep 2, 2026 9:12pm UTC

Request Review

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL labels Sep 2, 2026
@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown

Greptile Summary

This PR removes obsolete automatic settlement and conversation-naming behavior while retaining manual thread lifecycle controls.

  • Removes auto-settlement preferences and merged/inactive thread classification across clients.
  • Removes first-turn and provider-driven automatic thread renaming.
  • Simplifies General settings while restoring the mobile Project Grouping entry.
  • Updates shared contracts, tests, and thread-sidebar documentation.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously reported Project Grouping navigation issue is fixed by restoring a row whose target is registered and correctly wired.

Important Files Changed

Filename Overview
apps/mobile/src/features/settings/SettingsRouteScreen.tsx Removes the obsolete auto-settle switch while preserving a valid, reachable Project Grouping settings row.
packages/client-runtime/src/state/threadSettled.ts Restricts effective settlement behavior to the remaining manual lifecycle state.
apps/server/src/orchestration/Layers/ProviderCommandReactor.ts Removes automatic first-turn title generation while retaining other first-turn processing.
packages/contracts/src/orchestration.ts Updates orchestration contracts to remove the obsolete title-seed field.
apps/web/src/components/settings/SettingsPanels.tsx Removes obsolete General settings controls and presents the remaining model preference as the fallback model.

Reviews (5): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile

Comment thread apps/mobile/src/features/settings/SettingsRouteScreen.tsx
…d-thread-settings

# Conflicts:
#	apps/server/src/orchestration/Layers/ProviderCommandReactor.test.ts
@leoisadev1
leoisadev1 merged commit 11e2009 into main Sep 3, 2026
11 checks passed
@leoisadev1
leoisadev1 deleted the t3code/remove-outdated-thread-settings branch September 3, 2026 16:16
@github-actions github-actions Bot mentioned this pull request Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant