Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layer: ignore overlay.impure xattr #354

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

tych0
Copy link
Member

@tych0 tych0 commented Jan 25, 2021

See comment for details; basically this is a during-image-build-time-only
thing.

Signed-off-by: Tycho Andersen [email protected]

@tych0
Copy link
Member Author

tych0 commented Jan 25, 2021

I suppose we should probably ignore all the overlay xattrs (e.g. opaque or other things) with similar kinds of semantics... perhaps I should switch this patch to just ignore all of them. Let me know what you think.

@cyphar
Copy link
Member

cyphar commented Jan 28, 2021

Yeah it might not make sense to include any trusted.overlay attributes, though I would be worried a future attribute being added which actually should be kept by umoci...

@tych0
Copy link
Member Author

tych0 commented Jan 28, 2021

Yeah, perhaps I'll just update this and add all of the existing ones now, I think there's only ~6.

@tych0 tych0 force-pushed the ignore-overlay-impure branch 2 times, most recently from 60efe0e to 0db4a03 Compare January 28, 2021 14:36
See comment for details; basically these are during-image-build-time-only
things.

Signed-off-by: Tycho Andersen <[email protected]>
@tych0 tych0 force-pushed the ignore-overlay-impure branch from 0db4a03 to b171df2 Compare January 28, 2021 18:58
@codecov-io
Copy link

Codecov Report

Merging #354 (b171df2) into master (312f2f6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   74.20%   74.20%           
=======================================
  Files          58       58           
  Lines        3078     3078           
=======================================
  Hits         2284     2284           
  Misses        464      464           
  Partials      330      330           
Impacted Files Coverage Δ
oci/layer/tar_generate.go 71.42% <ø> (ø)

@tych0
Copy link
Member Author

tych0 commented Mar 5, 2021

Ping?

Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry.

@cyphar cyphar closed this in 130e11a Mar 6, 2021
@cyphar cyphar merged commit 130e11a into opencontainers:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants