Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutate: Add() should tell you what it added #344

Merged
merged 3 commits into from
Aug 20, 2020

Conversation

tych0
Copy link
Member

@tych0 tych0 commented Jul 15, 2020

a couple of commits to allow introspection of mutator

tych0 added 2 commits July 15, 2020 09:21
Right now, there's no way to find out the resulting descriptor that was
added to a mutator unless you Commit() it and look up the result. Let's
return the descriptor that was added to allow people to reason about it
without having to write even more to disk.

Signed-off-by: Tycho Andersen <[email protected]>
Note that this is a copy, so you can't actually make a change to the
original without using the real Add() etc. methods.

Signed-off-by: Tycho Andersen <[email protected]>
Similar to the previous patch where Add() tells you what it added.

Signed-off-by: Tycho Andersen <[email protected]>
@tych0
Copy link
Member Author

tych0 commented Aug 19, 2020

Ping?

@cyphar
Copy link
Member

cyphar commented Aug 20, 2020

LGTM, sorry for not looking at this for a while. 😢

@tych0 tych0 merged commit 95d647b into opencontainers:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants