-
Notifications
You must be signed in to change notification settings - Fork 54
proposals/distribution: remove non-sense about image indexes #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
stevvooe
wants to merge
1
commit into
opencontainers:add-distribution-proposal
from
stevvooe:add-distribution-proposal
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this is a first introduction of term "document." Suggest using this "spec."
Also this listing restriction does not make sense here. Can we move it to the Grouping line above on 109 and change the word grouping to a broader term like "managing?" "Managing the grouping of images (image names) as repositories within a registry is considered part of distribution policy or content management, which are out of scope for this spec."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The relationship between these two sentences is not straightforward. However I do think this is referring to slightly different functionality. While the "grouping" section is just saying that each repository name is considered independent from the perspective of the API, this is referring to an endpoint which lists all the repository names within a registry. While the group and name hierarchy could be of interest to an end API user, cataloging has normally just be considered an administrative endpoint not exposed to API users.
+1 on document -> specification
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool..
Maybe.. "An endpoint for listing repository names within a registry, is considered out of scope for this spec and thus also out of scope for this protocol." Or distribution protocol...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That language sounds clearer, let me update and move it next to tag listing. I don't think these statements belong here.