Add uint32 cast to unix.SELINUX_MAGIC#71
Merged
mrunalp merged 1 commit intoopencontainers:masterfrom Feb 27, 2020
Merged
Conversation
Otherwise this value will be treated as `int32`, which results in an build error in 386 environments: ``` selinux_linux.go:118:14: constant 4185718668 overflows int32 ``` Signed-off-by: Sascha Grunert <sgrunert@suse.com>
Collaborator
Contributor
|
LGTM |
Collaborator
|
Thanks for catching this! Looks like we need to have some kind of CI for this repo |
Contributor
Author
|
Yeah some cross compilation builds would be good. I think I can follow up on that :) |
This was referenced Feb 28, 2020
Member
|
@rhatdan is it possible to tag a v1.3.3 with this fix? (this regression was included in the latest v1.3.2 patch) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise this value will be treated as
int32, which results in anbuild error in 386 environments: