-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update runtime-spec v1.1.0 #771
Conversation
@kolyshkin @mrunalp ptal 🤗 |
Can we do a release without this change, and then another release with this change? The lack of a release with |
Or, we can put the |
b54a88a
to
7986994
Compare
OHMAN, I completely forgot v0.9.0 didn't have a go.mod
At least that won't hurt; I opened #773 |
As to the runtime-spec version, that's a really tricky one, and puts us in a rather awkward spot if you want to have a release with a go.mod that also has a "somewhat sensible" version of the spec, because currently, it's neither v1.0.x nor v1.1.x, and it's using a version that was never released as part of a v1.0.x; Looking at the v0.9.0 release, that's slightly better, as it uses a commit that's still v1.0.x ( runtime-tools/Godeps/Godeps.json Lines 36 to 40 in ee63cfa
Which is somewhere between v1.0.1 and v1.0.2 of the spec;
Looking at the first possible commit to tag with a That already gives us a version of the spec that's a v1.1.x ("ish"), because it's ahead of
If you depend on the So, I guess if the goal is to;
Then I THINK the only "real" solution would be to
The alternative would be to "move forward", and;
|
full diff: opencontainers/runtime-spec@86290f6...v1.1.0 Signed-off-by: Sebastiaan van Stijn <[email protected]>
7986994
to
27bf223
Compare
We could fork from 0.9 and release a 0.9.1 that "just" does the go.mod migration and upgrades to 1.0.2 (with cherry-picking if absolutely necessary). That way, we won't have to worry about reverting things from That being said, given that 0.9 was also a release that had a non-released spec version I think it's not too crazy to just say that 0.10 can similarly just be a fruity intermediate runtime-spec version in keeping with all of the other releases of runtime-tools, and we will stop doing that in future releases. |
Based on looking at the git logs, there was actually only one patch "needed" for us to support v1.0.2, so that approach seemed much simpler. See #774. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On reflection, just doing this is a better idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update some dependencies to released versions;
go.mod: github.com/opencontainers/runtime-spec v1.1.0
full diff: opencontainers/runtime-spec@86290f6...v1.1.0