Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to go mod #727

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Migrate to go mod #727

merged 2 commits into from
Oct 19, 2021

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Oct 14, 2021

This is a minimal migration from Godeps to native go modules, making it possible to use recent go versions.

Closes: #716
Closes: #704

@kolyshkin
Copy link
Contributor Author

The next steps would be to

  • replace travis-ci with github ci;
  • replace pullapprove with native github tools.

@kolyshkin
Copy link
Contributor Author

@opencontainers/runtime-tools-maintainers PTAL

@vbatts
Copy link
Member

vbatts commented Oct 18, 2021

bah! Travis!

Mostly done by

	go mod init
	go mod edit -go=1.16
	go mod tidy
	go mod vendor
	rm -rf Godeps
	git add vendor

Signed-off-by: Kir Kolyshkin <[email protected]>
This brings in Go 1.17+ build tags.

Signed-off-by: Kir Kolyshkin <[email protected]>
@caniszczyk
Copy link
Contributor

@vbatts LGTM if we just go with this and then I can find a way to pull Travis

@kolyshkin
Copy link
Contributor Author

@tianon looks like you can merge this now :)

@tianon tianon merged commit 4a0d318 into opencontainers:master Oct 19, 2021
@thaJeztah
Copy link
Member

Thanks!

@kolyshkin kolyshkin mentioned this pull request Oct 27, 2021
@kolyshkin kolyshkin mentioned this pull request Oct 18, 2022
@cyphar cyphar mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants