Add missing interface to set init processes Umask #706
Conversation
|
@mrunalp PTAL |
|
@haircommander PTAL |
|
I think we need to add corresponding options in the generate function to call this function. |
rhatdan
force-pushed
the
umask
branch
2 times, most recently
from
eadda1f to
829dfc5
Compare
|
@q384566678 Added. |
|
LGTM, thanks @rhatdan |
|
LGTM |
Umask is a field specified in the runtime spec, but we don't have a method to set it in runtime-tools. Some users might want to modify the default Umask of a container. Signed-off-by: Daniel J Walsh <[email protected]>
|
I am no longer a maintainer FYI 👍 |
|
@philips Your name is still listed, sorry for bothering you. |
|
LGTM |
|
@rhatdan where is it listed? I think i am gone from maintainers. |
|
Yeah the @opencontainers/runtime-tools-maintainers list needs to be updated. /cc @caniszczyk? |
| func (g *Generator) SetProcessUmask(umask uint32) { | ||
| g.initConfigProcess() | ||
| g.Config.Process.User.Umask = umask | ||
| } |
There was a problem hiding this comment.
This has changed to be an *uint32 with opencontainers/runtime-spec@d3f079a, which breaks compatibility between the tools and the spec of both latest master branches.
There was a problem hiding this comment.
Just found the same thing :)
There was a problem hiding this comment.
So, there is a PR to fix it (#708) but apparently it requires a new release of runtime-specs, for which there is an issue opened (opencontainers/runtime-spec#1052) but it's not yet done so...
Umask is a field specified in the runtime spec, but we don't
have a method to set it in runtime-tools. Some users might
want to modify the default Umask of a container.
Signed-off-by: Daniel J Walsh [email protected]