fix up vm parameters #676
Merged
fix up vm parameters #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with opencontainers/runtime-spec@fc51617 the runtime tools need to change as well to update the type. Do the simplest thing and simply allow multiple instances of the same argument to populate the array. Signed-off-by: Tycho Andersen <[email protected]>
|
LGTM, @vbatts please merge |
|
I kicked off the tests again |
|
Hrm, still seems busted? At least some of the errors look unrelated. |
|
hm. |
There are a few tests that have this version hardcoded and fail if it
doesn't exist in various external places like,
--- FAIL: TestJSONSchema (2.41s)
--- FAIL: TestJSONSchema/1_error_occurred:__*_Version_string_empty_Refer_to:_https://github.com/opencontainers/runtime-spec/blob/v1.0.1/config.md#specification-version (0.00s)
Error Trace: validate_test.go:267
Error: Not equal:
expected: "1 error occurred:\n\n* Version string empty\nRefer to: https://github.com/opencontainers/runtime-spec/blob/v1.0.1/config.md#specification-version"
actual: "1 error occurred:\n\n* Version string empty\nRefer to: https://github.com/opencontainers/runtime-spec/blob/v1.0.1-dev/config.md#specification-version"
-- FAIL: TestGenerateValid (0.16s)
generate_test.go:79: unexpected MUST error(s): 1 error occurred:
* Could not read schema from HTTP, response status is 404 Not Found
because it seems to be looking for:
https://raw.githubusercontent.com/opencontainers/runtime-spec/v1.0.1-dev/schema/config-schema.json
These probably shouldn't be hard coded, but I'll let someone from the
project figure out how to solve it :)
Signed-off-by: Tycho Andersen <[email protected]>
|
Ok, I figured this out, basically it's some version hard coding in the tests. It looks like there's not really a way for me to fix this, besides pretending it's not a -dev version that I imported. |
|
i see that [gross] hard coded bit. :- |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with opencontainers/runtime-spec@fc51617
the runtime tools need to change as well to update the type. Do the
simplest thing and simply allow multiple instances of the same argument to
populate the array.
Signed-off-by: Tycho Andersen [email protected]