validation: add a new test for NSPathMatchTypeError #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouhao3
reviewed
May 29, 2018
validation/linux_ns_path_type.go
Outdated
|
|
||
| err = util.RuntimeOutsideValidate(g, func(config *rspec.Spec, state *rspec.State) error { | ||
| return nil | ||
| }) |
There was a problem hiding this comment.
I think this will be better: err = util.RuntimeOutsideValidate(g, nil)
There was a problem hiding this comment.
@q384566678 Right. I've changed it as you suggested.
`checkNSPathMatchType` checks if the container returns an error when deliberately setting a wrong namespace type. Doing that, it is possible to verify `NSPathMatchTypeError`, i.e. `The runtime MUST generate an error if path is not associated with a namespace of type "type"`. See also opencontainers#572 Signed-off-by: Dongsu Park <[email protected]>
dongsupark
force-pushed
the
dongsu/test-path-match-type
branch
from
d4961ab to
1fb00d9
Compare
We should use an existing helper `util.GetRuntimeToolsNamespaces()` instead of writing an internal function again. Signed-off-by: Dongsu Park <[email protected]>
|
Rebased, and added another commit to use an existing helper function |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkNSPathMatchTypechecks if the container returns an error when deliberately setting a wrong namespace type. Doing that, it is possible to verifyNSPathMatchTypeError, i.e.The runtime MUST generate an error if path is not associated with a namespace of type "type".See also #572
/cc @alban
Signed-off-by: Dongsu Park [email protected]