Add cgroupsPath validation #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouhao3
force-pushed
the
cgroups-validation
branch
2 times, most recently
from
4bc5e81 to
3078423
Compare
|
@liangchenye PTAL |
liangchenye
reviewed
May 3, 2018
| if _, err := os.Stat(path); err != nil { | ||
| if os.IsNotExist(err) { | ||
| return nil, specerror.NewError(specerror.CgroupsAbsPathRelToMount, fmt.Errorf("In the case of an absolute path, the runtime MUST take the path to be relative to the cgroups mount point"), rspec.Version) | ||
| } |
There was a problem hiding this comment.
return nil, err in case of getting other error?
liangchenye
reviewed
May 3, 2018
| if _, err := os.Stat(path); err != nil { | ||
| if os.IsNotExist(err) { | ||
| return nil, specerror.NewError(specerror.CgroupsAbsPathRelToMount, fmt.Errorf("In the case of an absolute path, the runtime MUST take the path to be relative to the cgroups mount point"), rspec.Version) | ||
| } |
There was a problem hiding this comment.
same, return error in case of other error.
liangchenye
reviewed
May 3, 2018
| if _, err := os.Stat(path); err != nil { | ||
| if os.IsNotExist(err) { | ||
| return nil, specerror.NewError(specerror.CgroupsAbsPathRelToMount, fmt.Errorf("In the case of an absolute path, the runtime MUST take the path to be relative to the cgroups mount point"), rspec.Version) | ||
| } |
There was a problem hiding this comment.
return error in case of other error
liangchenye
reviewed
May 3, 2018
| if _, err := os.Stat(path); err != nil { | ||
| if os.IsNotExist(err) { | ||
| return nil, specerror.NewError(specerror.CgroupsAbsPathRelToMount, fmt.Errorf("In the case of an absolute path, the runtime MUST take the path to be relative to the cgroups mount point"), rspec.Version) | ||
| } |
liangchenye
reviewed
May 3, 2018
| if _, err := os.Stat(path); err != nil { | ||
| if os.IsNotExist(err) { | ||
| return nil, specerror.NewError(specerror.CgroupsAbsPathRelToMount, fmt.Errorf("In the case of an absolute path, the runtime MUST take the path to be relative to the cgroups mount point"), rspec.Version) | ||
| } |
liangchenye
reviewed
May 3, 2018
| if _, err := os.Stat(path); err != nil { | ||
| if os.IsNotExist(err) { | ||
| return nil, specerror.NewError(specerror.CgroupsAbsPathRelToMount, fmt.Errorf("In the case of an absolute path, the runtime MUST take the path to be relative to the cgroups mount point"), rspec.Version) | ||
| } |
There was a problem hiding this comment.
the last place.
Besides these, it looks good to me.
Implement the following specerror: CgroupsAbsPathRelToMount: In the case of an absolute path (starting with `/`), the runtime MUST take the path to be relative to the cgroups mount point. CgroupsPathAttach: If the value is specified, the runtime MUST consistently attach to the same place in the cgroups hierarchy given the same value of `cgroupsPath`. Signed-off-by: Zhou Hao <[email protected]>
zhouhao3
force-pushed
the
cgroups-validation
branch
from
3078423 to
3e3094d
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the following specerror:
CgroupsAbsPathRelToMount: In the case of an absolute path (starting with
/), the runtime MUST take the path to be relative to the cgroups mount point.CgroupsPathAttach: If the value is specified, the runtime MUST consistently attach to the same place in the cgroups hierarchy given the same value of
cgroupsPath.Signed-off-by: Zhou Hao [email protected]