validation: implement PosixHooksCalledInOrder test

[zhouhao3]

Signed-off-by: Zhou Hao [email protected]

[liangchenye]

1. I prefer to rename it to hooksorder.go .
2. We need to verify 'poststart/poststop' as well.

   echo prestart1 > output_prestart
   echo prestart2 > output_prestart
   verify prestart hook order
   echo poststart1 > output_poststart
   echo poststart2 > output_poststart
   verify poststart hook order
   echo poststop1 > output_poststop
   echo poststop2 > output_poststop
   verify poststop hook order

[zhouhao3]

When poststart and poststop execute errors, only warnings are output without error, so if the last err is nil, and the result isn't we expect. it is hard to determine whether it is an execution error or not in order. So I only used prestart for testing.

[liangchenye]

I think in the order tests, we have the assumption: every hook ('echo') will be executed collect， we just test the 'order'.

[zhouhao3]

updated, and I think hook.go would be better.

[wking]

No need for a prestart1 temporary variable, you can just use:

err := g.AddPreStartHook(rspec.Hook{
  …
})
if err != nil {
  return err
}

That also checks this call's returned error, which you're currently ignoring.

[wking]

You use this Join a lot in this test. Maybe store it in a temporary variable:

shPath := filepath.Join(r.BundleDir, g.Spec().Root.Path, "/bin/sh")
…
  Path: shPath,

[zhouhao3]

updated, thanks.

[liangchenye]

LGTM