validate: add weightDevice validation

[zhouhao3]

According to the following specifications:
You MUST specify at least one of weight or leafWeight in a given entry, and MAY specify both.

implement BlkIOWeightOrLeafWeightExist.

Signed-off-by: Zhou Hao [email protected]

[wking]

From Travis:

validate/validate_test.go:568:10: missing type in composite literal
validate/validate_test.go:568:10: implicit assignment of unexported field 'linuxBlockIODevice' in specs.LinuxWeightDevice literal

[zhouhao3]

I don't know what to do with this, but I tried the following calls, and they all went wrong.

 WeightDevice: []rspec.LinuxWeightDevice{
        linuxBlockIODevice{
                Major: 5,
                Minor: 0,
        },
}

 WeightDevice: []rspec.LinuxWeightDevice{
        rspec.linuxBlockIODevice{
                Major: 5,
                Minor: 0,
        },
}

[wking]

I don't know what to do with this, but I tried the following calls, and they all went wrong.

I'm pretty sure you want:

WeightDevice: []rspec.LinuxWeightDevice{
  rspec.LinuxWeightDevice{
    Major: 5,
    Minor: 0,
  },
},

[zhouhao3]

This is still wrong.

[wking]

This is still wrong.

Hmm. Maybe Go has a problem with literal struct initialization for lowercase embedded types. We may need to skip these for the literal initialization and add them later via the promoted properties:

weightDevices := []rspec.LinuxWeightDevice{
  rspec.LinuxWeightDevice{},
}
weightDevices[0].Major = 5
weightDevices[0].Minor = 0

Then use WeightDevice: weightDevices when you initialize your config struct.

[zhouhao3]

Cool. It worked, thanks.

[wking]

This string is already covered by BlkIOWeightOrLeafWeightExist. I think we want something like:

for i, weightDevice := range r.BlockIO.WeightDevice {
    …
        fmt.Errorf("linux.resources.blockIO.weightDevice[%d] specifies neither weight nor leafWeight", i)
    …
}

[zhouhao3]

updated, thanks.

[zhouhao3]

@liangchenye PTAL

[zhouhao3]

ping @liangchenye

[liangchenye]

I'm working on implement 'kill' this morning.
I'll review it this afternoon. @q384566678

[liangchenye]

LGTM