generate: update rootfs releated options #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
reviewed
Oct 21, 2016
| cli.StringFlag{Name: "rootfs", Value: "rootfs", Usage: "path to the rootfs"}, | ||
| cli.StringFlag{Name: "rootfs-path", Value: "rootfs", Usage: "path to the rootfs"}, | ||
| cli.StringFlag{Name: "rootfs-propagation", Usage: "mount propagation for rootfs"}, | ||
| cli.BoolFlag{Name: "rootfs-readonly", Usage: "make the container's rootfs readonly"}, |
Contributor
There was a problem hiding this comment.
The config.json property is root, so I'd prefer sticking to root instead of switching to rootfs. Other than that these changes look good to me.
Author
There was a problem hiding this comment.
OK. Then, let's see what's other people's opinions?
man/oci-runtime-tool-generate.1.md
Outdated
| **--rootfs-readonly**=true|false | ||
| Mount the container's root filesystem as read only. | ||
|
|
||
| By default a container will have its root filesystem writable allowing processes to write files anywhere. By specifying the `--read-only` flag the container will have its root filesystem mounted as read only prohibiting any writes. |
Contributor
There was a problem hiding this comment.
This --read-only instance is stale.
Mashimiao
force-pushed
the
generate-update-rootfs-options
branch
from
1a27740 to
b4b41f9
Compare
Signed-off-by: Ma Shimiao <[email protected]>
Mashimiao
force-pushed
the
generate-update-rootfs-options
branch
from
b4b41f9 to
d0d4f2d
Compare
Contributor
|
LGTM |
Author
|
ping @opencontainers/runtime-tools-maintainers |
Contributor
|
LGTM |
Contributor
|
@mrunalp Needs your re-LGTM. |
Contributor
|
LGTM |
wking
added a commit
to wking/ocitools-v2
that referenced
this pull request
Jul 11, 2017
Adjusting a --rootfs instance that was missed in d0d4f2d (generate: update rootfs releated options, 2016-10-21, opencontainers#254). Signed-off-by: W. Trevor King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ma Shimiao [email protected]
After updated, options of rootfs will be more human-readable and easy to understand