update godeps and use by makefile #231

Mashimiao · 2016-10-07T07:17:08Z

update dependencies to the latest version
and add directory vendor as _workspace will be deprecated in go1.8

Signed-off-by: Ma Shimiao [email protected]

liangchenye · 2016-10-09T13:45:20Z

I'm fine to update this.
But I prefer to do it after most other PRs been merged.

mrunalp · 2016-10-11T18:12:29Z

Yeah, let's get the other ones in.

Mashimiao · 2016-11-14T07:49:33Z

@opencontainers/runtime-tools-maintainers
Can we let this in first? I think there are many differences between spec v1.0.0-rc1 and v1.0.0-rc2.
The backward spec-go has affected usage. like mentioned in #268

wking · 2016-11-23T07:53:32Z

.travis.yml

 sudo: false

 before_install:
+  - go get github.com/tools/godep


Why this addition? Does Travis start using godep somewhere?

godep will be used in Makefile

Ah, I'd missed that between all the Godeps removals and vendor additions.

Mashimiao · 2017-04-11T02:25:08Z

As #349 is landed, can we start to review this PR?
@liangchenye @mrunalp

Mashimiao · 2017-05-10T10:54:30Z

ping @liangchenye @mrunalp @hqhq

liangchenye · 2017-07-04T06:20:51Z

golint in make test will check all the files under vendor directory, so the CI fails.

Can you skip this in Makefile? @Mashimiao

Mashimiao · 2017-07-04T06:36:40Z

@liangchenye yes, updated. I think there is no need to exit with output of golint

liangchenye · 2017-07-04T06:44:44Z

LGTM

hqhq · 2017-07-04T07:04:43Z

@Mashimiao What tool are you using? Just godep or tools like vndr?

Why there's no config file for dependencies?

Mashimiao · 2017-07-04T07:36:39Z

Just use godep. sorry for leave the config behind.
@liangchenye @hqhq PTAL

hqhq · 2017-07-04T07:58:38Z

Godeps/Godeps.json

+		},
+		{
+			"ImportPath": "golang.org/x/sys/unix",
+			"Rev": "f3918c30c5c2cb527c0b071a27c35120a6c0719a"


Why do you need to add this in this PR?

automatically added by godep, not sure if it should be here. But as unix also is called and depended by runtime-tools, I think may be it's OK

I find runc or image-tools also add them into vendor directory

They use x/sys/unix to replace syscall package, maybe it's used by the updated vendors, it's fine if is automatically added.

hqhq · 2017-07-04T09:08:59Z

Makefile


 .govet:
-	go vet -x ./...
+	OUT=$$(go vet ./... | grep -v "exit status" | grep -v vendor); if test -n "$${OUT}"; then echo "$${OUT}" && exit 1; fi


I would do something like:

packages = $(shell go list ./... | grep -v vendor) .govet: go vet $(packages)

updated, PTAL

Not exactly what I expected, but we can do that later.

remove test files in dependencies add directory vendor as _workspace will be deprecated in go1.8 Signed-off-by: Ma Shimiao <[email protected]>

As _workspace is deprecated and support for it will be removed when go1.8 is released. I think RUNTIME_TOOLS_LINK will not be needed any more Signed-off-by: Ma Shimiao <[email protected]>

Signed-off-by: Ma Shimiao <[email protected]>

hqhq · 2017-07-04T09:44:35Z

LGTM

liangchenye · 2017-07-04T10:45:31Z

LGTM

We used to use this option but it's reverted in opencontainers#231 , not sure about the reason, it's simpler than to use the OUT hack. Signed-off-by: Qiang Huang <[email protected]>

Generated with: $ godep save ./... $ git mv Godeps/_workspace/src/github.com/xeipuuv/ vendor/github.com/ I'm not sure why I need the 'git mv ...'. We've been keeping our vendored content there since aab108d (update godeps and use by makefile, 2017-03-24, opencontainers#231), but my godep is still trying to save the content under Godeps/_workspace. Maybe it's because my system Go is still 1.7.4? Signed-off-by: W. Trevor King <[email protected]>

Mashimiao force-pushed the update-godeps-on-latest-version branch 2 times, most recently from dcb08e9 to 7975741 Compare October 7, 2016 07:36

Mashimiao force-pushed the update-godeps-on-latest-version branch 2 times, most recently from bc4a30a to 148ae00 Compare November 14, 2016 07:21

Mashimiao mentioned this pull request Nov 23, 2016

cmd/runtimetest: Add an app description #277

Merged

wking reviewed Nov 23, 2016

View reviewed changes

Mashimiao mentioned this pull request Mar 24, 2017

Switch to using vendor directory #351

Closed

Mashimiao force-pushed the update-godeps-on-latest-version branch 2 times, most recently from 7ae267b to 1168ef5 Compare March 24, 2017 02:07

Mashimiao force-pushed the update-godeps-on-latest-version branch 5 times, most recently from da8931f to 4c7392f Compare April 11, 2017 02:22

Mashimiao modified the milestone: 0.6 Apr 11, 2017

Mashimiao force-pushed the update-godeps-on-latest-version branch from 4c7392f to a01adbc Compare July 4, 2017 05:34

Mashimiao force-pushed the update-godeps-on-latest-version branch from a01adbc to 662d87e Compare July 4, 2017 06:35

hqhq reviewed Jul 4, 2017

View reviewed changes

Mashimiao force-pushed the update-godeps-on-latest-version branch from 2dc42f7 to 89178d7 Compare July 4, 2017 08:13

Mashimiao force-pushed the update-godeps-on-latest-version branch 2 times, most recently from eb6c0c7 to c7c0082 Compare July 4, 2017 08:36

hqhq reviewed Jul 4, 2017

View reviewed changes

Ma Shimiao added 4 commits July 4, 2017 17:12

update godeps and use by makefile

aab108d

remove test files in dependencies add directory vendor as _workspace will be deprecated in go1.8 Signed-off-by: Ma Shimiao <[email protected]>

remove RUNTIME_TOOLS_LINK

3547188

As _workspace is deprecated and support for it will be removed when go1.8 is released. I think RUNTIME_TOOLS_LINK will not be needed any more Signed-off-by: Ma Shimiao <[email protected]>

use godeps to manage dep version

760b1fd

Signed-off-by: Ma Shimiao <[email protected]>

ignore fmt error from vendor

7c5ce64

Signed-off-by: Ma Shimiao <[email protected]>

Mashimiao force-pushed the update-godeps-on-latest-version branch from c7c0082 to 7c5ce64 Compare July 4, 2017 09:27

liangchenye merged commit b8f1cb9 into opencontainers:master Jul 4, 2017

hqhq mentioned this pull request Jul 5, 2017

Makefile: use -set_exit_status for golint #413

Merged

Mashimiao removed this from the v0.6.0 milestone Sep 15, 2017

update godeps and use by makefile #231

update godeps and use by makefile #231

Uh oh!

Conversation

Mashimiao commented Oct 7, 2016

Uh oh!

liangchenye commented Oct 9, 2016

Uh oh!

mrunalp commented Oct 11, 2016

Uh oh!

Mashimiao commented Nov 14, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mashimiao commented Apr 11, 2017

Uh oh!

Mashimiao commented May 10, 2017

Uh oh!

liangchenye commented Jul 4, 2017

Uh oh!

Mashimiao commented Jul 4, 2017

Uh oh!

liangchenye commented Jul 4, 2017 • edited by caniszczyk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hqhq commented Jul 4, 2017

Uh oh!

Mashimiao commented Jul 4, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hqhq commented Jul 4, 2017 • edited by caniszczyk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liangchenye commented Jul 4, 2017 • edited by caniszczyk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

liangchenye commented Jul 4, 2017 •

edited by caniszczyk

Loading

hqhq commented Jul 4, 2017 •

edited by caniszczyk

Loading

liangchenye commented Jul 4, 2017 •

edited by caniszczyk

Loading