Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host-specific and platform overlapped in validation #414

Closed
liangchenye opened this issue Jul 6, 2017 · 4 comments
Closed

host-specific and platform overlapped in validation #414

liangchenye opened this issue Jul 6, 2017 · 4 comments

Comments

@liangchenye
Copy link
Member

While reviewing #187,
I checked both generate and validate logic.

In validate.go, we have both 'host-specific' and 'platform',
I think we should overwrite the platform when we have 'host-specific' option.

@liangchenye
Copy link
Member Author

Fix #414
PTAL @mrunalp @hqhq @Mashimiao

@liangchenye
Copy link
Member Author

fixed, close

@wking
Copy link
Contributor

wking commented Jul 10, 2017 via email

@liangchenye liangchenye reopened this Jul 11, 2017
@liangchenye
Copy link
Member Author

+1 for add a 'warning' to fix a.a.b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants