config-windows: fix the type of maximum #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhouhao <[email protected]>
Member
|
LGTM |
wking
approved these changes
Jul 14, 2017
Mashimiao
approved these changes
Jul 15, 2017
Contributor
|
LGTM |
Contributor
|
This PR now has two LGTMs and no pushback. Can we merge it into master? Are we waiting for more maintainers to chime in in case the change does turn out to be contentious? Are we waiting until we settle on a post-1.0 branching strategy (this seems like a patch-level bump regardless of what APIs SemVer covers)? Something else? |
Author
Member
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/opencontainers/runtime-spec/blame/master/specs-go/config.go#L459
https://github.com/opencontainers/runtime-spec/blame/master/schema/config-windows.json#L43
Signed-off-by: zhouhao [email protected]