config: Drop the redundant config.json filename requirement #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because:
1. This section defines the configuration format, and doesn't need to
be tied to a particular filename.
2. The bundle spec (in bundle.md) already has:
This REQUIRED file MUST reside in the root of the bundle
directory and MUST be named `config.json`.
The config.md line may have been useful when it was added (77d44b1,
Update runtime.md, 2015-07-16). But since the bundle.md line landed
in 106ec2d (Cleanup bundle.md, 2015-10-02, opencontainers#210), I think it's been
redundant.
Signed-off-by: W. Trevor King <[email protected]>
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This section defines the configuration format, and doesn't need to be tied to a particular filename.
The bundle spec (in
bundle.md) already has:The config.md line may have been useful when it was added (77d44b1). But since the bundle.md line landed in 106ec2d (#210), I think it's been redundant.