Fix the build by getting rid of go get for vet #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This will probably fail for 1.4.* |
Contributor
Author
|
@vbatts Do we want to get rid of testing on older go versions? |
Signed-off-by: Mrunal Patel <[email protected]>
Member
|
well, deprecating 1.3 and 1.4 would clean up the golint situation... |
Contributor
Author
|
@vbatts done. |
Member
|
LGTM |
Contributor
Author
|
@crosbymichael @LK4D4 PTAL |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They got rid of the repo. See https://groups.google.com/forum/#!searchin/golang-announce/vet|sort:relevance/golang-announce/qu_rAphYdxY/SR5jL9IDBgAJ
Thanks to @liangchenye for reporting.
Signed-off-by: Mrunal Patel [email protected]