systemd cgroup: check for Delegate property #865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| hasDelegate = true | ||
| dl := newProp("Delegate", true) | ||
| if _, err := theConn.StartTransientUnit(scope, "replace", []systemdDbus.Property{dl}, nil); err != nil { |
Member
There was a problem hiding this comment.
Don't you have to destroy this unit first (the same name is used by the previous test)? Or is this dealt with by the "stop unit logic"?
Contributor
Author
There was a problem hiding this comment.
oops i must have done something wrong when checking it in. Fixed now.
Delegate is only available in systemd >218, applying it for older systemd will result in an error. Therefore we should check for it when testing systemd properties. Signed-off-by: Daniel, Dao Quang Minh <[email protected]>
dqminh
force-pushed
the
runc-systemd-version
branch
from
f89d45b to
d5ecf5c
Compare
Member
|
LGTM |
Contributor
|
LGTM |
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
fix docs.oracle.com links opencontainers#864
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #801
Delegate is only available in systemd >218, applying it for older systemd will
result in an error. Therefore we should check for it when testing systemd
properties.