Set oom_score_adj before we send the config to avoid race #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mrunal Patel <[email protected]>
Contributor
Author
Contributor
Author
|
Fix for the broken test is in #669 |
Member
|
Yes, running with that change, the error is no longer reproducible with runc exec test_busybox echo Hello. |
Contributor
Author
|
@mikebrow Thanks! Basically with this change we are relying on the synchronization for passing down config. We also set the cgroups before passing the config for the same reason. This escaped under the radar during review. |
Member
|
Ok! I'll write up some stress test cases to try and catch bootstrap issues for start and exec. Cheers |
Contributor
|
Test failed. |
Member
Contributor
|
All right, I see #669 fixed this. |
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
mrunalp
pushed a commit
that referenced
this pull request
Mar 22, 2016
Set oom_score_adj before we send the config to avoid race
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Closes opencontainers#668 Signed-off-by: Michael Crosby <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mrunal Patel [email protected]